Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The current working directory must be exist #558

Merged
merged 1 commit into from
Feb 5, 2018
Merged

The current working directory must be exist #558

merged 1 commit into from
Feb 5, 2018

Conversation

zce
Copy link
Contributor

@zce zce commented Aug 11, 2017

The current working directory must be exist, there is no need to check whether the directory exists again

The current working directory must be exist
@posva
Copy link
Member

posva commented Aug 11, 2017

That check doesn't look necessary, what is the case you want to handle?

@zce
Copy link
Contributor Author

zce commented Aug 29, 2017

The exist(to) always return true when inPlace is true, I just think it's possible to skip a call here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants