Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not allow process custom file (fix #1879) #1889

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

@haoqunjiang
Copy link
Member

Thanks for the help.

The tests are passing.

But the previous code comment says that it fixed an issue that ts-loader is inappropriately applied to non-vue files.
So I need some additional time to confirm that deleting these lines doesn't cause new bugs.

Copy link
Member

@haoqunjiang haoqunjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it and didn't find regressions. So I think it's good to go.

A safer fix is to replace !/\.vue(\.html)?$/.test with /\.[jt]sx?$/.test. But now that I didn't encounter issues by deleting these statements, I'll go on with this fix, and only add them back when there are specific bug reports.

@haoqunjiang haoqunjiang merged commit f32f953 into vuejs:next Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants