Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inject): hasOwn instead of 'in' (fix #7284) #7460

Merged
merged 2 commits into from
Mar 8, 2018
Merged

fix(inject): hasOwn instead of 'in' (fix #7284) #7460

merged 2 commits into from
Mar 8, 2018

Commits on Jan 16, 2018

  1. fix(Injection with Symbol polyfill): hasOwn instead of 'in' 

    Symbol polyfill adds a setter on the Object prototype so the 'in' check evaluated to true on every
object

fix vuejs#7284
    Hiroki Osame committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    9d4b0c3 View commit details
    Browse the repository at this point in the history

  2. test(Injected properties): Ensures prototype properties aren't injected 

    Prototype properties were being injected, so injecting 'constructor' would have hit the first
provide-layer and not yield expected results.

fix vuejs#7284
    Hiroki Osame committed Jan 16, 2018
    Configuration menu
    Copy the full SHA
    df248f3 View commit details
    Browse the repository at this point in the history