Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Numeral Mask + External Lib Formatter For v-text-field #2235

Closed
wants to merge 18 commits into from
Closed

Enhancement: Numeral Mask + External Lib Formatter For v-text-field #2235

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
fc9d26d
Enhancement: Numeral Mask + External Lib Formatter For v-text-field
azaars Oct 18, 2017
2663063
Attempt to resolve CODEBEAT issues
azaars Oct 20, 2017
e33d0c5
More of CODEBEAT & some CODE CLIMATE
azaars Oct 20, 2017
d2cd49c
Merge remote-tracking branch 'vuetifyjs/dev' into object-typed-mask
azaars Oct 21, 2017
76228e7
Post-review 1
azaars Oct 21, 2017
27f8632
Merge remote-tracking branch 'vuetifyjs/dev' into object-typed-mask
azaars Oct 23, 2017
de6c268
Post-review 2: Code optimization
azaars Oct 23, 2017
8f1b428
Zap CODEBEAT & CODECLIMATE
azaars Oct 23, 2017
32106a0
Merge remote-tracking branch 'vuetifyjs/dev' into object-typed-mask
azaars Oct 24, 2017
4368168
Post-review 3: Code optimization
azaars Oct 24, 2017
ddca0a3
Removes unneeded checking of typeof for no-mask case
azaars Oct 30, 2017
27977a5
Sync with https://github.com/vuetifyjs/vuetify/pull/2360
azaars Oct 31, 2017
7809b28
Merge branch 'dev' into object-typed-mask
azaars Nov 6, 2017
e887e1e
Merge remote-tracking branch 'vuetifyjs/dev' into object-typed-mask
azaars Dec 28, 2017
73e5ce2
Improvements to bypass internal mask operations on external formatter.
azaars Dec 29, 2017
867936f
Removes changes to yarn.lock
azaars Dec 29, 2017
d70ce4f
Merge remote-tracking branch 'vuetifyjs/dev' into object-typed-mask
azaars Dec 31, 2017
2939e07
Merge branch 'dev' into object-typed-mask
azaars Jan 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/mixins/numeral-formatable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export default {
return this.parseNumber(text)
},
maskNumeralText (text) {
if (!text) return this.addPrefixSuffix(this.precision ? '0.' + this.getFraction('') : '0')
if (!text) return this.numeralZero()
text = this.sign ? String(text).substr(1) : String(text)

const param = {
Expand Down Expand Up @@ -122,6 +122,9 @@ export default {
if (isNaN(parsed)) return 0
return Math.abs(parsed)
},
numeralZero () {
return this.addPrefixSuffix(this.precision ? '0.' + this.getFraction('') : '0')
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be a computed property so it can be cached.

adjustNumeralCaret (selection, text) {
// Caret is at prefix
if (selection === 0) return this.numeralPrefix.length + this.sign.length
Expand Down