Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update vue to 2.5.21 #5789

Merged
merged 14 commits into from
Dec 12, 2018
Merged

chore: update vue to 2.5.21 #5789

merged 14 commits into from
Dec 12, 2018

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Dec 3, 2018

Blocked by vuejs/vue#9131 and vuejs/vue#8498

Resolves #5633

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@vercel
Copy link

vercel bot commented Dec 3, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #5789 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5789      +/-   ##
==========================================
+ Coverage   89.05%   89.06%   +<.01%     
==========================================
  Files         262      262              
  Lines        5923     5924       +1     
  Branches     1468     1468              
==========================================
+ Hits         5275     5276       +1     
  Misses        532      532              
  Partials      116      116
Impacted Files Coverage Δ
...mponents/VExpansionPanel/VExpansionPanelContent.ts 84.84% <ø> (ø) ⬆️
packages/vuetify/src/components/VBadge/VBadge.ts 100% <ø> (ø) ⬆️
packages/vuetify/src/mixins/dependent.ts 100% <ø> (ø) ⬆️
packages/vuetify/src/mixins/bootable.ts 100% <ø> (ø) ⬆️
packages/vuetify/src/components/VChip/VChip.ts 100% <ø> (ø) ⬆️
packages/vuetify/src/mixins/routable.ts 100% <ø> (ø) ⬆️
...ages/vuetify/src/components/VWindow/VWindowItem.ts 100% <ø> (ø) ⬆️
packages/vuetify/src/components/VAlert/VAlert.ts 100% <ø> (ø) ⬆️
.../vuetify/src/components/VPagination/VPagination.ts 100% <ø> (ø) ⬆️
...ages/vuetify/src/components/VTreeview/VTreeview.ts 99.35% <ø> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a1b483...fd11c59. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

Merging #5789 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5789      +/-   ##
==========================================
+ Coverage   89.17%   89.26%   +0.08%     
==========================================
  Files         262      262              
  Lines        5923     5971      +48     
  Branches     1467     1489      +22     
==========================================
+ Hits         5282     5330      +48     
+ Misses        528      524       -4     
- Partials      113      117       +4
Impacted Files Coverage Δ
packages/vuetify/src/mixins/bootable.ts 100% <ø> (ø) ⬆️
...ages/vuetify/src/components/VWindow/VWindowItem.ts 100% <ø> (ø) ⬆️
packages/vuetify/src/components/VAlert/VAlert.ts 100% <ø> (ø) ⬆️
...ages/vuetify/src/components/VTreeview/VTreeview.ts 99.35% <ø> (ø) ⬆️
packages/vuetify/src/components/VWindow/VWindow.ts 100% <ø> (ø) ⬆️
.../vuetify/src/components/VPagination/VPagination.ts 100% <ø> (ø) ⬆️
packages/vuetify/src/mixins/routable.ts 100% <ø> (ø) ⬆️
packages/vuetify/src/mixins/dependent.ts 100% <ø> (ø) ⬆️
...ages/vuetify/src/components/VSnackbar/VSnackbar.ts 94.73% <100%> (-0.51%) ⬇️
packages/vuetify/src/components/VCard/index.ts 100% <100%> (ø) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e91a9c...3233be8. Read the comment docs.

@jacekkarczmarczyk jacekkarczmarczyk changed the title chore: update vue to 2.5.18 chore: update vue to 2.5.19 Dec 10, 2018
@jacekkarczmarczyk jacekkarczmarczyk changed the title chore: update vue to 2.5.19 chore: update vue to 2.5.21 Dec 11, 2018
@KaelWD KaelWD merged commit ae31593 into master Dec 12, 2018
@KaelWD KaelWD deleted the chore/vue-2.5.18 branch December 12, 2018 10:52
johnleider added a commit that referenced this pull request Dec 12, 2018
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Maximum call stack size exceeded
2 participants