Windows+Cmake #17
Merged
Windows+Cmake #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levlam
suggested changes
Jan 2, 2021
CMakeLists.txt
Outdated
| @@ -0,0 +1,23 @@ | |||
| cmake_minimum_required(VERSION 3.0) | |||
| project(tl-parser) | |||
CMakeLists.txt
Outdated
| @@ -0,0 +1,23 @@ | |||
| cmake_minimum_required(VERSION 3.0) | |||
CMakeLists.txt
Outdated
| add_definitions("-D_CRT_SECURE_NO_WARNINGS") | ||
| list(APPEND SOURCES wgetopt.c wgetopt.h) | ||
| if (MSVC) | ||
| set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /SUBSYSTEM:CONSOLE") |
There was a problem hiding this comment.
Isn't "CONSOLE" a default value of /SUBSYSTEM?
CMakeLists.txt
Outdated
| endif() | ||
|
|
||
| # Set the output directories to the cmake build directory | ||
| set(CMAKE_RUNTIME_OUTPUT_DIRECTORY_DEBUG .) |
There was a problem hiding this comment.
This shouldn't be needed. Other CMake projects can use target's name instead of full path to tl-parser executable.
crc32.h
Outdated
| unsigned compute_crc32 (const void *data, int len); | ||
| unsigned compute_crc32_combine (unsigned crc1, unsigned crc2, int len2); | ||
|
|
||
| extern unsigned long long crc64_table[256]; |
crc32.h
Outdated
|
|
||
| Case force_exit == 1 (case 1, 2: kprintf call, case -1: assert fail). | ||
| */ | ||
| int crc32_check_and_repair (void *input, int l, unsigned *input_crc32, int force_exit); |
There was a problem hiding this comment.
This function and other unused functions can be deleted.
arves100
force-pushed
the
master
branch
2 times, most recently
from
4f2cc7f to
f001d17
Compare
|
@levlam updated the new commit with the changes you requested |
|
Squashed commit was fine. |
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16