Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version histories are showing incorrect deprecation dates #966

Closed
mcking65 opened this issue Mar 18, 2024 · 2 comments
Closed

Version histories are showing incorrect deprecation dates #966

mcking65 opened this issue Mar 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@mcking65
Copy link

mcking65 commented Mar 18, 2024

The last deployment of the app broke an important working mode requirement.

The deprecation date of a test plan that was deprecated during candidate review should be the same date that the newer version was advanced to candidate. There are several test plans where the deprecation date of plans deprecated during candidate review are incorrect.

I remember spending a lot of time checking this functionality for nearly all test plans last summer, and I believe we resolved all inconsistencies. Now it appears there are regressions in the functionality and data has changed in unexpected ways.

For example, look at the alert example on the candidate review page. It shows that the candidate review start date is Jan 11, 2024.

image

However, you can see from the timeline for all versions of the alert test plan that candidate review of the alert test plan started on Dec 9, 2022 when V22.12.08 advanced to candidate.

image

While the alert plan has the correct deprecation date for v22.12.08 when V23.12.06 was advanced to candidate review, there are other test plans where the deprecation date is inconsistent with other dates in the timeline. For example, look at the Disclosure Navigation Menu Example Test Plan.
For this test plan, the timeline shows that Candidate Review Started on Dec 1, 2021 when V21.11.30 advanced to candidate. The timeline also shows that V21.11.30 was deprecated on Dec 1, 2021. Look further down the timeline and you can see that the next version to advance to candidate was V22.10.31 on Nov 1, 2022. So, that should be the deprecation date for V21.11.30. In addition, the candidate review and data management pages show that candidate review started on Nov 1, 2022 but the versions timeline shows that candidate review started Dec 1, 2021. I question that Dec 1, 2021 date, though; I don't remember when we first advanced a plan to candidate, but that seems earlier than I recall. At any rate, the timeline is inconsistent.

screenshot of disclosure test plan timeline

Similarly, in the Radio Group Example Using aria-activedescendant Test Plan, the deprecation date for the version that was deprecated when V23.04.10 advanced to candidate is incorrect. V23.04.10 advanced to candidate on Apr 11, 2023. When it advanced, it deprecated V22.05.18. However, the deprecation date shown for V22.05.18 is Dec 8, 2022, but it should be Apr 11, 2023. The data management and candidate review pages show that candidate review started on Apr 11, 2023, but it actually started on May 19, 2022.

@mcking65 mcking65 added the bug Something isn't working label Mar 18, 2024
@howard-e
Copy link
Contributor

howard-e commented Mar 19, 2024

When a test plan advances to candidate, if there is an earlier version of that plan in candidate review, the candidate review start and target completion dates should not be changed. Now, the candidate review start dates are incorrect for all test plans in candidate review. In addition, target dates were changed for all test plans advanced after the latest release of the app, so they are also incorrect. We can no longer see how overdue those plans are.

As agreed in another discussion, the above is a one issue and the rest of the top comment is another so they will be handled separately.

@ccanash ccanash changed the title Candidate review start date is errantly reset when a test plan advances to candidate and version histories are showing incorrect deprecation dates Version histories are showing incorrect deprecation dates Mar 20, 2024
@ccanash
Copy link
Contributor

ccanash commented Mar 20, 2024

Hi @mcking65 created task #973 with the first part of your comment, updated the title of this issue and also modified the task description.

howard-e added a commit that referenced this issue Jun 5, 2024
howard-e added a commit that referenced this issue Jun 12, 2024
June 12, 2024 Release

Issues addressed:
* #1111, addresses #1107
* #1114, addresses #1106
* #1112, addresses #966
* #1127
@ccanash ccanash closed this as completed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants