Embed feature #476
Merged
Embed feature #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howard-e
reviewed
Dec 21, 2022
| </div> | ||
| {{/if}} | ||
| {{#unless dataEmpty}} | ||
| {{#if (isCandidate status)}} |
There was a problem hiding this comment.
isRecommended can also be checked for now. The text the app is currently using is:
The information in this report is generated from recommended tests. Recommended ARIA-AT tests have been reviewed by assistive technology developers and represent consensus regarding: applicability and validity of the tests, and accuracy of test results.
This comes from #471.
howard-e
approved these changes
Dec 21, 2022
alflennik
reviewed
Dec 21, 2022
server/handlebars/public/script.js
Outdated
| }; | ||
|
|
||
| window.parent.postMessage( | ||
| `{ height: ${document.body.scrollHeight}, iframe: ${iframeClass} }`, |
There was a problem hiding this comment.
This actually doesn't need to be a string, it can be a normal object!
| height="500" | ||
| allow="clipboard-write" | ||
| style="border-style: none; width: 100%;"> | ||
| </iframe>`; |
There was a problem hiding this comment.
Could we format the string like this? This formatting would require less correction when embedded.
` <iframe
class="${iframeClass}"
src="${link}"
height="500"
allow="clipboard-write"
style="border-style: none; width: 100%;">
</iframe>`;
evmiguel
force-pushed
the
embed-feature
branch
from
7cde6a9 to
e4d7c8c
Compare
howard-e
approved these changes
Dec 22, 2022
evmiguel
added a commit
that referenced
this pull request
Dec 22, 2022
* handlebars bootstrap * Structural implementation * Open reports page on button click * Initial styling pass * button styling * Adding JS behaviors * Prod config * Fixing pathing issue for environments * APG integration fixes * Adding condition for no data * Adding view cache * Reports sorted by AT with logic to populate columns * Remove console statement * Cleanup * Post message as object instead of string * Addressing PR feedback, adding copied message to the right, and adding window resize listener * Adding recommended notice * Removing cacheing * Make responsive (#477) * Surface AT version * Adding caching Co-authored-by: Alexander Flenniken <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the embed feature for support levels. It uses handlebars for templating and serves the embeddable page on the server side.
To see the page, go to http://localhost:3000/embed/reports/command-button