Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed feature [2] #479

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Embed feature [2] #479

merged 3 commits into from
Jan 11, 2023

Conversation

howard-e
Copy link
Contributor

Changes to iframe based on feedback shared in w3c/aria-practices#2569

  • Adding H3 title for pattern.

@howard-e howard-e marked this pull request as ready for review January 11, 2023 15:17
@howard-e howard-e requested a review from evmiguel January 11, 2023 16:02
@howard-e
Copy link
Contributor Author

cc @ChrisC

evmiguel
evmiguel approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@evmiguel evmiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Nice job with the customizable title feature and finding typos.

@howard-e howard-e merged commit f4667c7 into main Jan 11, 2023
@howard-e howard-e deleted the embed-feature-2 branch January 11, 2023 19:05
@howard-e howard-e mentioned this pull request Jan 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evmiguel evmiguel evmiguel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@howard-e @evmiguel