Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address support tables 2.0 feedback #521

Merged
merged 11 commits into from
Mar 27, 2023
Merged

Address support tables 2.0 feedback #521

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
99813f7
Address support tables 2.0 feedback
alflennik Mar 13, 2023
3b9b688
Fix candidate recommended algorithm
alflennik Mar 15, 2023
a7056e6
Add additional caching
alflennik Mar 16, 2023
3b2f725
Add test
alflennik Mar 21, 2023
9dca1c5
Resolve circular dependency issue
alflennik Mar 21, 2023
07c2197
Support slower environments in test
alflennik Mar 21, 2023
b605249
Implement basic test
alflennik Mar 23, 2023
0c3aea9
Finish tests
alflennik Mar 23, 2023
0066529
Support even slower environments
alflennik Mar 23, 2023
d6b4f4c
Fix non local environments
alflennik Mar 27, 2023
6699a39
Fix test environment
alflennik Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/handlebars/public/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ const iframeCode = link =>
`<iframe
class="${iframeClass}"
src="${link}"
height="500"
height="100"
allow="clipboard-write"
style="border-style: none; width: 100%;">
</iframe>`;
Expand Down
10 changes: 7 additions & 3 deletions server/handlebars/public/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,12 @@ h3#report-title {
display: inline-block;
}

#candidate-title.recommended h3 {
width: 130px;
#candidate-title.recommended {
border: 1.5px solid #7ac498;
alflennik marked this conversation as resolved.
Show resolved Hide resolved
background-color: #e9fbe9;
}
#candidate-title.recommended > span {
background-color: #115b11;
}

#candidate-content-container {
Expand All @@ -90,7 +94,7 @@ h3#report-title {
margin-bottom: 3px;
}

.none {
.no-data-cell {
display: block;
color: #72777f;
font-style: italic;
Expand Down
18 changes: 8 additions & 10 deletions server/handlebars/views/main.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
<div id="main">
{{#if dataEmpty}}
<h3 id="report-title">{{title}}</h3>
<div id="no-data-container">
<div id="no-data-content-container">
There is no data for this pattern.
Expand All @@ -13,26 +12,25 @@
<summary id="candidate-title"><span>Warning! Unapproved Report</span></summary>
<div id="candidate-content-container">
The information in this report is generated from candidate tests developed and run by the <a href="http://aria-at.w3.org">ARIA-AT Project</a>.
ARIA-AT tests are in review by assistive technology developers and lack consensus regarding:
Candidate ARIA-AT tests are in review by assistive technology developers and lack consensus regarding:
<ol>
<li>applicability and validity of the tests, and</li>
<li>accuracy of test results.</li>
</ol>
</div>
</details>
{{else}}
<div id="embed-report-status-container">
<div id="candidate-title" class="recommended"><h3>Recommended Report</h3></div>
<details id="embed-report-status-container">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the markup to allow the RECOMMENDED disclaimer to be a part of the updated disclosure as well!

<summary id="candidate-title" class="recommended"><span>Recommended Report</span></summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be curious about what the community's thoughts would on this title. Should the disclaimer also be the reverse of the CANDIDATE disclaimer, so Approved Report?

This is also done on the application's Reports pages as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have them review it. Can we promote one of the reports to a recommended state on the sandbox?

<div id="candidate-content-container">
The information in this report is generated from recommended tests.
Recommended ARIA-AT tests have been reviewed by assistive technology
developers and represent consensus regarding
Recommended ARIA-AT tests have been reviewed by assistive technology developers and represent consensus regarding:
<ol>
<li>applicability and validity of the tests, and</li>
<li>accuracy of test results.</li>
</ol>
</div>
</div>
</details>
{{/if}}
<div class="responsive-table">
<table id="embed-report-table" aria-label="Assistive Technology Support for {{title}}">
Expand Down Expand Up @@ -61,7 +59,7 @@
{{else}}
{{#if (isInAllBrowsers "Chrome" @../../this) }}
{{#unless (elementExists @../../this @../this this.at.name "Chrome" @last)}}
<td><span class="none">None</span></td>
<td><span class="no-data-cell">No Data</span></td>
{{/unless}}
{{/if}}
{{/if}}
Expand All @@ -77,7 +75,7 @@
{{else}}
{{#if (isInAllBrowsers "Firefox" @../../this) }}
{{#unless (elementExists @../../this @../this this.at.name "Firefox" @last)}}
<td><span class="none">None</span></td>
<td><span class="no-data-cell">No Data</span></td>
{{/unless}}
{{/if}}
{{/if}}
Expand All @@ -93,7 +91,7 @@
{{else}}
{{#if (isInAllBrowsers "Safari" @../../this) }}
{{#unless (elementExists @../../this @../this this.at.name "Safari" @last)}}
<td><span class="none">None</span></td>
<td><span class="no-data-cell">No Data</span></td>
{{/unless}}
{{/if}}
{{/if}}
Expand Down