Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect NVDA Bot responses: "Navigate to the bottom of a modal dialog" (Modal Dialog Example, Test 14.1, V24.05.09) #1070

Closed
IsaDC opened this issue May 20, 2024 · 5 comments
Assignees
Labels
Agenda+Community Group To discuss in the next workstream summary meeting (usually the last teleconference of the month) feedback Issue raised by or for collecting input from people outside the core project team. nvda

Comments

@IsaDC
Copy link
Contributor

IsaDC commented May 20, 2024

Description of Behavior

I still getting the results from the previous NVDA version.

Test Setup

@IsaDC IsaDC added Agenda+Community Group To discuss in the next workstream summary meeting (usually the last teleconference of the month) feedback Issue raised by or for collecting input from people outside the core project team. nvda labels May 20, 2024
@IsaDC
Copy link
Contributor Author

IsaDC commented May 21, 2024

Now I get this when trying to re-run the test plan:

  • AT: NVDA 2023.3.3
  • Browser: Chrome 99
    There are no results to evaluate.
    I have already tried signing out and back in and performing a hard refresh, but the issue persists.

Cc @jugglinmike

@IsaDC
Copy link
Contributor Author

IsaDC commented May 21, 2024

Then, when I finally get some results, they don't match with the manual results. E.G.

<style> </style>
Test Bot Results Manual Results
Test 6:Navigate to the bottom of a modal dialog A blank line button    Verify Address  button    Add  button    Cancel
Test 8:Bump into the top edge of a modal dialog A blank line heading    level 2  Add Delivery Address

 

@mcking65 mcking65 changed the title Feedback: "Navigate to the bottom of a modal dialog" (Modal Dialog Example, Test 14.1, V24.05.09) Incorrect NVDA Bot responses: "Navigate to the bottom of a modal dialog" (Modal Dialog Example, Test 14.1, V24.05.09) May 22, 2024
@gnarf
Copy link
Contributor

gnarf commented May 22, 2024

I set this up for modal tests with NVDA/chrome on the staging site (which is using the same automation backend) and it responded using 2024.1, I'm not sure where the old version results were sneaking in, but all new NVDA automation runs should be 2024.1 since May 9

The "blank line" results are confusing, they don't seem related to the other keypress errors, I'll have to do some local testing to see if I can get a screen recording of it running this test.

@gnarf
Copy link
Contributor

gnarf commented May 22, 2024

The empty results were tracked down to a problem with these tests rowNumber property being a decimal (14.1 as well as 14).

PR w3c/aria-at-app#1105 solves this issue and the fix was deployed to staging. The results of that run are still streaming in, but show the same as your manual testing for number 6 https://aria-at-staging.w3.org/run/575?user=9999

@gnarf gnarf self-assigned this May 22, 2024
howard-e added a commit to w3c/aria-at-app that referenced this issue May 28, 2024
Issues addressed:
* #1105, addresses w3c/aria-at#1070
* #1053, addresses w3c/aria-practices#2971
* #1097, addresses #977
* #1095, addresses #991
* #1093, addresses #934
* #1000, addresses #818
* #1089, addresses #992
* #1067, addresses #993
* #1056, addresses w3c/wai-aria-practices#212

---------

Co-authored-by: alflennik <[email protected]>
Co-authored-by: Paul Clue <[email protected]>
Co-authored-by: Mx Corey Frang <[email protected]>
Co-authored-by: Mx. Corey Frang <[email protected]>
Co-authored-by: Erika Miguel <[email protected]>
Co-authored-by: Mike Pennisi <[email protected]>
@ccanash ccanash moved this to In production / Completed in 2024 Ops and maintenance support for ARIA-AT and APG Jun 3, 2024
@ccanash
Copy link

ccanash commented Jun 3, 2024

Hi @IsaDC , this was released . I will close it but please let me know if anything is not working as expected

@ccanash ccanash closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agenda+Community Group To discuss in the next workstream summary meeting (usually the last teleconference of the month) feedback Issue raised by or for collecting input from people outside the core project team. nvda
Projects
Status: In production / Completed
Development

No branches or pull requests

3 participants