Skip to content

Commit

Permalink
Infrastructure: Source heading for read this first content from aria-…
Browse files Browse the repository at this point in the history
…practices repo (pull #2867)

Moves the h2 element that is part of the "Read This First" content from the wai-aria-practices repo into the aria-practices repo. This is part of an effort to ensure all content is sourced and controlled from the aria-practices repo and the wai-aria-practices repo provides only transformations necessary for site build.
  • Loading branch information
Paul-Clue authored Dec 11, 2023
1 parent 4bb1946 commit 4a3531f
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions content/shared/templates/example-usage-warning.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<meta charset="utf-8">
<title>Support Notice (Template)</title>
<body>
<h2 id="support-notice-header">Read This First</h2>
<details id="support-notice">
<summary>
The code in this example is not intended for production environments.
Expand Down

4 comments on commit 4a3531f

@a11ydoer
Copy link
Contributor

@a11ydoer a11ydoer commented on 4a3531f Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Paul-Clue @mcking65 @howard-e @alflennik

This commit causes two H2 headings to appear on the pattern page.

@alflennik
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a11ydoer Thank you for noticing this, a fix is here w3c/wai-aria-practices#286 and we are fast tracking it.

Side note that I think the issue was caused by merge conflict resolution, not this PR itself.

@a11ydoer
Copy link
Contributor

@a11ydoer a11ydoer commented on 4a3531f Dec 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting me know @alflennik

@alflennik
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix was deployed yesterday! Things are working properly again.

Please sign in to comment.