Skip to content

Commit

Permalink
Infrastructure: Fix problem running regression from Windows command line
Browse files Browse the repository at this point in the history
Changes command aliases in package.json to move test globbing to the Ava configuration to solve issues where Windows wasn't able to find files when using wildcards to specify which tests to run via the command line.
npm scripts run command line operations using syntax features of the operating system. 
With this change, when running regression tests from the command line,  Ava will use its own internal globbing algorithm (globby), which has cross-platform support.

* fix: don't glob in scripts
* fix: use ava config to glob tests

Signed-off-by: Evan Yamanishi <[email protected]>
  • Loading branch information
sh0ji authored and mcking65 committed Jan 14, 2020
1 parent 0d79d21 commit d9d83a8
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"lint:es": "eslint .",
"lint:js": "npm run lint:es",
"lint:html": "npm run vnu-jar",
"regression": "ava test/tests/*.js",
"regression": "ava",
"regression-report": "node test/util/report",
"test": "npm run lint && npm run regression",
"vnu-jar": "java -jar node_modules/vnu-jar/build/dist/vnu.jar --errors-only --filterfile .vnurc --no-langdetect --skip-non-html *.html examples/"
Expand Down Expand Up @@ -55,5 +55,10 @@
"eslint --fix",
"git add"
]
},
"ava": {
"files": [
"test/tests/*"
]
}
}

0 comments on commit d9d83a8

Please sign in to comment.