Combobox examples: Make clicking outside popup close the popup #1265
Assignees
Labels
bug
Code defects; not for inaccurate prose
Example Page
Related to a page containing an example implementation of a pattern
Milestone
Comments
mcking65
added
bug
This was referenced Nov 14, 2019
6 tasks
6 tasks
mcking65
added a commit
that referenced
this issue
Feb 14, 2020
…raction, visual design, and more (pull #1276) Fixes #785, #982, #983, #988, #1261, #1265, and #1268 with the following changes: * updated JavaScript to use single prototype * updated escape key behavior * removed unused files * fixed regression issues for escape key * updated tests for single and double escape key tests * fixed focus bug on enter and removed use of keycode property * fixed bug in opening list and improved property names for visual focus flags * fixed bug in opening list with alt key pressed * fixed bug with enter key not updating aria-expanded * fixed bugs with down arrow * added documentation and tests for ALT Down Arrow * fixed some styling bugs * Use only one SVG image to show listbox state * updated CSS for styling listbox focus * fixed scrolling issue in listbox * adjusted position of svg image button * fixed onclik bug where not selecting options when autocomplete is list or none * updated test for autocomplete, list and none * fixed bug with onclick behavior and documented option filtering as users type * updated documentation about filtering of options * Typo: character -> characters * fixed option filter bug with autocomplete=none * improved description of when listbox opens * use lowercase "the" in sentence * Minor editorial revision to alt+down in textbox keyboard table * udpated test file to check for aria-selected on option when listbox opens * fixed aria-selected tests * add tests for aria-selected to key down tests * Add aria-hidden=false and focusable=false to svg in button * Use fewer descendant combinators in selectors * Call function instead of setting a property on elements * Don't call setValue() when hitting backspace, to avoid moving the cursor to the end * Remove superfluous isPrintableCharacter() call * Remove unused variable textContent * Declare option outside for loop. Also use null instead of false * Set scrollTop once * Declare index variable in the if block * Move isPrintableCharacter to ComboboxAutocomplete.prototype * Add information about the id attribute for all combobox examples; fixes #785 Co-authored-by: Carolyn MacLeod <[email protected]> Co-authored-by: Matt King <[email protected]> Co-authored-by: Valerie Young <[email protected]> Co-authored-by: Simon Pieters <[email protected]>
michael-n-cooper
pushed a commit
that referenced
this issue
Feb 14, 2020
Combobox Examples with listbox popup: Fix Escape behavior, mouse interaction, visual design, and more (pull #1276) Fixes #785, #982, #983, #988, #1261, #1265, and #1268 with the following changes: * updated JavaScript to use single prototype * updated escape key behavior * removed unused files * fixed regression issues for escape key * updated tests for single and double escape key tests * fixed focus bug on enter and removed use of keycode property * fixed bug in opening list and improved property names for visual focus flags * fixed bug in opening list with alt key pressed * fixed bug with enter key not updating aria-expanded * fixed bugs with down arrow * added documentation and tests for ALT Down Arrow * fixed some styling bugs * Use only one SVG image to show listbox state * updated CSS for styling listbox focus * fixed scrolling issue in listbox * adjusted position of svg image button * fixed onclik bug where not selecting options when autocomplete is list or none * updated test for autocomplete, list and none * fixed bug with onclick behavior and documented option filtering as users type * updated documentation about filtering of options * Typo: character -> characters * fixed option filter bug with autocomplete=none * improved description of when listbox opens * use lowercase "the" in sentence * Minor editorial revision to alt+down in textbox keyboard table * udpated test file to check for aria-selected on option when listbox opens * fixed aria-selected tests * add tests for aria-selected to key down tests * Add aria-hidden=false and focusable=false to svg in button * Use fewer descendant combinators in selectors * Call function instead of setting a property on elements * Don't call setValue() when hitting backspace, to avoid moving the cursor to the end * Remove superfluous isPrintableCharacter() call * Remove unused variable textContent * Declare option outside for loop. Also use null instead of false * Set scrollTop once * Declare index variable in the if block * Move isPrintableCharacter to ComboboxAutocomplete.prototype * Add information about the id attribute for all combobox examples; fixes #785 Co-authored-by: Carolyn MacLeod <[email protected]> Co-authored-by: Matt King <[email protected]> Co-authored-by: Valerie Young <[email protected]> Co-authored-by: Simon Pieters <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Per review of the combobox examples by @smhigley in #1255, the listbox/grid popup does not close when clicking outside of it (detailed comment on why in the #1255 review of
combobox-list.js).The text was updated successfully, but these errors were encountered: