-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sortable table fails without at least one column that is not sorted #2904
Labels
bug
Code defects; not for inaccurate prose
Example Page
Related to a page containing an example implementation of a pattern
Feedback
Issue raised by or for collecting input from people outside APG task force
Milestone
Comments
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> Topic: Sortable table bug<jugglinmike> github: https://github.com//issues/2904 <jugglinmike> Matt_King: There is a pull request which addresses this <jugglinmike> Matt_King: The issue looked pretty well-documented to me <jugglinmike> Matt_King: They're saying that if all the columns are sortable, you end up with this problem <jugglinmike> Matt_King: They're changing our example. Our example doesn't work if you make all the columns sortable <jugglinmike> siri: If the column is not sorted, nothing is visually provided to the users that indicates that the column is sortable (not until I hover over it or give focus to it) <jugglinmike> Matt_King: That was a design decision because we didn't want to clutter the table with a bunch of icons. No one does that in the real world <jugglinmike> Matt_King: The table allows you to sort by multiple criteria, but ARIA sort doesn't support this, and so neither does the visual presentation here <Jem> https://www.w3.org/WAI/ARIA/apg/patterns/table/examples/sortable-table/ <jugglinmike> CurtBellew: At Oracle, we do offer sortable tables where the "sort" icon is always present <jugglinmike> CurtBellew: And here in APG, that's also available when enabling the example's option labeled "Display sort icon in headers of sortable columns that are not sorted" <jugglinmike> Matt_King: Ah, so Siri's preferred behavior is available with this option. Siri's feedback is about changing the default behavior <jugglinmike> CurtBellew: Oracle's implementation looks slightly different (using an "up" arrow and a "down" arrow instead of a diamond shape), but it matches Siri's expectation <jugglinmike> Matt_King: In any case, this is a separate issue than what's been reported <jugglinmike> Zakim, end the meeting |
mcking65
added
bug
Code defects; not for inaccurate prose
Example Page
Related to a page containing an example implementation of a pattern
Feedback
Issue raised by or for collecting input from people outside APG task force
labels
Jul 27, 2024
github-project-automation
bot
moved this to Complete
in Table Pattern and Example Development Project
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Code defects; not for inaccurate prose
Example Page
Related to a page containing an example implementation of a pattern
Feedback
Issue raised by or for collecting input from people outside APG task force
Sortable table is a great example. But it seems to fail unless (at least?) one column is marked non-sortable. If everything is sortable then the top header row is shrunken in height and the active zone is very small.
Is this a known problem? Seems surprising that it hasn't been noticed before, since sorting all columns seems common.
I didn't find the issue in the issue database, which is surprising to me. I'm happy to generate an example if this is not a known problem.
-- Malcolm
The text was updated successfully, but these errors were encountered: