Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Menubar Example: When focus is in 2nd level submenu, Escape is closing both submenus instead of focusing on parent in first level submenu. #595

Closed
katiehockman opened this issue Feb 5, 2018 · 5 comments
Assignees
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force question Issue asking a question

Comments

@katiehockman
Copy link

https://www.w3.org/TR/wai-aria-practices/#menu
"Escape: Close the menu that contains focus and return focus to the element or context, e.g., menu button or parent menuitem, from which the menu was opened."

Technically, if in a submenu then the element that opened that submenu would be the menuitem one level up. The example in the APG shows that Escape closes the entire menu, instead of just the current submenu though. Could this be made clearer in the APG of what to do in the case of currently being in a submenu?

@0ddfell0w
Copy link

Potentially a duplicate of #451

@mcking65
Copy link
Contributor

mcking65 commented Feb 5, 2018

katiehockman commented:

https://www.w3.org/TR/wai-aria-practices/#menu
"Escape: Close the menu that contains focus and return focus to the element or context, e.g., menu button or parent menuitem, from which the menu was opened."

Technically, if in a submenu then the element that opened that submenu would be the menuitem one level up. The example in the APG shows that Escape closes the entire menu, instead of just the current submenu though. Could this be made clearer in the APG of what to do in the case of currently being in a submenu?

That sounds like a bug in the example. Which example is closing more than one level of menu?

@mcking65 mcking65 added question Issue asking a question Feedback Issue raised by or for collecting input from people outside APG task force labels Feb 5, 2018
@mcking65 mcking65 added this to the 1.1 APG Release 2 milestone Feb 5, 2018
@0ddfell0w
Copy link

If you open the first menubar example and navigate to the Admissions > Tuition submenu and hit escape, focus should be applied to "Tuition" but instead is applied to "Admissions"

@mcking65 mcking65 changed the title When focus is in submenu, should Escape close the entire menu? Navigation Menubar Example: When focus is in 2nd level submenu, Escape is closing both submenus instead of focusing on parent in first level submenu. Jun 24, 2018
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern labels Jun 24, 2018
@jongund
Copy link
Contributor

jongund commented Jun 25, 2018

Fix is in pull request 740

@mcking65
Copy link
Contributor

This is fixed with commit 15b87d9. Thank you @jongund!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern Feedback Issue raised by or for collecting input from people outside APG task force question Issue asking a question
Development

No branches or pull requests

4 participants