-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menubar Examples: When focus is in menubar, Escape should close any open submenus #451
Comments
It seems to work with keyboard (IE 11). Pressing the Escape key sets keyboard focus on the parent menu item. |
I saw this issue on Mac Chrome. Esc works when focus was inside one of the submenus, but not when focus is on the menubar and a submenu is shown. You can repro by pressing right/left when a submenu is shown, then pressing Esc |
I am not observing the problem with escape key not closing menus in the current menubar branch |
@mcking65 In your second testing scenario, it is testing the escape key function when the focus is on parent menu, menubar item "Admissions", not on submenu(role=menuitem). |
ok. Group agrees that escape key should close wherever the focus is. The keyboard part of Menu, not submenu and coding and spec will be updated. |
@jongund, With d9a1f79, this issue is fixed in the editor menubar (menubar2). However, we still have two open Escape key issues with the navigation menubar (menubar1):
|
Fix is in pull request 740 |
In the
navigation menubar example,
when users tab into the menubar, the submenu associated with the focused menubar menuitem is displayed, covering content underneath. There is no way to hide the submenu without tabbing out of the menubar. Shouldn't the Escape key hide the submenu?
To reproduce:
Expected result: The "About" menu collapses.
Actual result: Nothing happens.
Similarly, while the "About" menu item has focus, continue by:
Expected result: The "Admissions" menu collapses.
Actual result: Nothing happens.
The text was updated successfully, but these errors were encountered: