Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs Pattern: Missing labeling guidance for the tablist element #620

Closed
brooksienoodlesoup opened this issue Mar 16, 2018 · 1 comment
Closed
Labels
bug Code defects; not for inaccurate prose Feedback Issue raised by or for collecting input from people outside APG task force Pattern Page Related to a page documenting a Pattern

Comments

@brooksienoodlesoup
Copy link

Hi,
This is Brooks Newton writing to suggest an addition to the design pattern definition of 3.21 Tabs in the ARIA Authoring Practices 1.1. Specifically, I think there needs to be guidance on how content authors should label a tabs widget as a whole, so that it is identifiable to assistive technology users. My suggestion would be to advise content authors to supply a label for the element with role="tablist" via aria-labelledby or aria-label markup. The working tabs examples you link to in 3.21 Tabs (automatic and manual activation) employ this tab list naming technique, however the design pattern instructions for WAI-ARIA Roles, States, and Properties doesn't mention providing an accessible name for the element with role="tablist".

Thanks for Your Consideration,
Brooks

@mcking65 mcking65 added bug Code defects; not for inaccurate prose documentation Feedback Issue raised by or for collecting input from people outside APG task force Pattern Page Related to a page documenting a Pattern labels Jun 23, 2018
@mcking65 mcking65 added this to the 1.1 APG Release 2 milestone Jun 23, 2018
mcking65 added a commit that referenced this issue Jul 20, 2018
For issue #620, changed the roles, states, and properties section of the tabs pattern in aria-practices.html.

State aria-labelledby or aria-label is used to label the tablist element.
@mcking65
Copy link
Contributor

This is resolved in commit 55b113f, which adds the language:

If the tab list has a visible label, the element with role tablist has aria-labelledby set to a value that refers to the labeling element. Otherwise, the tablist element has a label provided by aria-label.

@mcking65 mcking65 changed the title How to supply the accessible name for tabs (tab panel) widget Tabs Pattern: Missing labeling guidance for the tablist element Jul 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code defects; not for inaccurate prose Feedback Issue raised by or for collecting input from people outside APG task force Pattern Page Related to a page documenting a Pattern
Development

No branches or pull requests

2 participants