Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree view - contradiction re:selection following focus #652

Closed
kbae00 opened this issue Apr 19, 2018 · 3 comments
Closed

Tree view - contradiction re:selection following focus #652

kbae00 opened this issue Apr 19, 2018 · 3 comments
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Feedback Issue raised by or for collecting input from people outside APG task force Pattern Page Related to a page documenting a Pattern question Issue asking a question

Comments

@kbae00
Copy link

kbae00 commented Apr 19, 2018

Near the beginning of the Tree view article, the APG says "If the tree allows the user to choose just one item for an action, then it is known as a single-select tree, and the item with focus also has a selected state. However, in multi-select trees, which enable the user to select more than one item for an action, the selected state is independent of the focus." I read that as saying that if it's a single-select tree, selection should follow focus.

However, in the Notes section, selection-follows-focus seems to be optional:

This seems like a contradiction or at least it's not 100% clear.

@0ddfell0w
Copy link

0ddfell0w commented Apr 19, 2018

the APG says "If the tree allows the user to choose just one item for an action, then it is known as a single-select tree, and the item with focus also has a selected state. However, in multi-select trees, which enable the user to select more than one item for an action, the selected state is independent of the focus." I read that as saying that if it's a single-select tree, selection should follow focus.

I don't think you should read that as saying a single-select tree should always have selection following focus. It's just pointing out that it's impossible for selection to follow focus in a multi-select tree. In a single select tree, it's a choice

@katiehockman
Copy link

I agree kbae00 that it is a bit misleading. The fact that the APG says, in the scope of a single-select tree, "the item with focus also has a selected state" that is describing selection-follows-focus. Maybe rewording it would be enough. Saying something like this might be clearer:
"In multi-select trees, which enable the user to select more than one item for an action, the selected state is independent of the focus. However, if the tree allows the user to choose just one item for an action, then it is known as a single-select tree, and selection-follow-focus may be implemented such that the item with focus also has a selected state."

@mcking65 mcking65 added Feedback Issue raised by or for collecting input from people outside APG task force question Issue asking a question editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Pattern Page Related to a page documenting a Pattern labels Jun 24, 2018
@mcking65 mcking65 added this to the 1.1 APG Release 2 milestone Jun 24, 2018
mcking65 added a commit that referenced this issue Jun 25, 2018
…ocus in single-selects

For issue #652, modified tree view pattern in aria-practices.html:
* Changed wording of paragraph in the pattern introduction that describes single-select and multi-select trees.
* Added a link to the section with guidance on when  to choose to have  selection  follow focus.
@mcking65
Copy link
Contributor

@0ddfell0w is right, but I agree with @kbae00 that the language is not consistent.

So, I pushed commit c7860cc.

If this does not address the issue fully, please feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Feedback Issue raised by or for collecting input from people outside APG task force Pattern Page Related to a page documenting a Pattern question Issue asking a question
Projects
None yet
Development

No branches or pull requests

4 participants