Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal Dialog Example: HTML source displays in wrong color #738

Closed
mcking65 opened this issue Jun 25, 2018 · 0 comments
Closed

Modal Dialog Example: HTML source displays in wrong color #738

mcking65 opened this issue Jun 25, 2018 · 0 comments
Assignees
@sh0ji
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Milestone
1.1 APG Release 2

Comments

@mcking65
Copy link
Contributor

The color of the source code display in the modal dialog is incorrect.

@annabbott commented in issue #101:

Modal Dialog Example > HTML Source Code: all text is displayed in red instead of black, blue and red like in Alert Dialog Example > HTML Source Code.

@sh0ji commented:

This appears to be an issue with the latest editor's draft from master. It's likely a separate issue.
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation labels Jun 25, 2018
@mcking65 mcking65 added this to the 1.1 APG Release 2 milestone Jun 25, 2018
@sh0ji sh0ji self-assigned this Jun 25, 2018
@sh0ji sh0ji mentioned this issue Jun 25, 2018
Merged
mcking65 pushed a commit that referenced this issue Jun 27, 2018
@sh0ji @mcking65
Modal Dialog Example: Fix HTML source display highlighting (pull #741)
dc1ed44 
Fix issue #738 by adding missing app.js script and fixing HTML source display wrapper.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sh0ji sh0ji

Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
None yet
Milestone
1.1 APG Release 2
Development

No branches or pull requests
2 participants
@mcking65 @sh0ji