-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guidelines for range related properties #1279
Conversation
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<carmacleod> TOPIC: range related properties<carmacleod> mck: did we resolve the questions about undetermined value? (i.e. min and max undefined) <carmacleod> simon: spinbutton is an example that allows undefined min and max <carmacleod> mck: progressbar too <carmacleod> mck: we don't have an apg example of something that doesn't have a defined range <Jemma> for aria widget status, are you starting from here, https://www.w3.org/TR/wai-aria-1.1/#attrs_widgets? <zcorpan> https://pr-preview.s3.amazonaws.com//pull/1279.html#range_related_properties <zcorpan> GitHub: https://github.com//pull/1279 <Jemma> Communicating Value for Range Widgets <Jemma> aria-valuetext Defines a description of the value of the element. <carmacleod> simon: I added an example of an undetermined progressbar <carmacleod> jon: need more on when to use aria-valuetext <carmacleod> jon: how should you think about valuemin and valuemax if you have valuetext <carmacleod> jon: i.e. if we have low, medium, high, do I put in 1 for min and 3 for max? <carmacleod> simon: aria spec says you can _also_ use valuetext as well as min and max, so unless spec changes, we need to have min and max <carmacleod> simon: if it's required for the role <carmacleod> jon: if it's a price range, screen readers only say the text <carmacleod> mck: if I want to know the range, I type home and end key to find min and max <Jemma> +q <Jemma> https://pr-preview.s3.amazonaws.com//pull/1279.html#range_related_properties_using_aria-valuemin_and_aria-valuemax <carmacleod> mck: some will communicate percentage and some will communicate actual values (I think spinbuttons say value, and sliders say percentage) <carmacleod> ack jem <Jemma> https://rawcdn.githack.com/w3c/aria-practices/1f7d940ca9872ff2f240c65ce4520338fbdbd3c6/examples/meter/meter.html <carmacleod> simon: for progressbar, min and max default to 0 and 100; for meter, authors are required to provide min and max |
@a11ydoer found the table for |
I have also tried to clarify the table itself, by changing "none" to "no default", and the table heading "Required?" to "Are |
I'm not certain what to say about the purpose of |
@mcking65 @zcorpan I like the battery example, but does it need to include Also what is the guidance for some thing like a range of costs and aria-valuetext? |
Thanks, @carmacleod, I've applied your suggestions. @jongund I think your question is the topic of w3c/aria#1128 |
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<MarkMccarthy> TOPIC: Guidance section - range related properties<MarkMccarthy> Matt_King: i'm probably just going to push some commits. have 4 minor editorial changes to make <Jemma> https://github.com//pull/1279 <MarkMccarthy> Matt_King: one thing though, we have a section abour progress, scroll bars, spinbuttons and a couple more in section 8.4, but not meters. <carmacleod> github: https://github.com//pull/1279 <MarkMccarthy> Matt_King: i wonder if someone might make a similar section for meter? <MarkMccarthy> s/in section 8.4/sections for each <MarkMccarthy> carmacleod: i can't, have some work stuff that has to come first. <MarkMccarthy> Matt_King: understandable. <MarkMccarthy> Matt_King: we could merge without, just seems like an oversight to me <MarkMccarthy> Jemma: i can do it if I have more info, since I did the meter example <MarkMccarthy> Matt_King: sure, if you want to draft it. essentially, if you look at section 8.6, you could copy most of that and replace phrases where appropriate <MarkMccarthy> Matt_King: you'd have to do inline example code though <MarkMccarthy> Matt_King: yeah, literally can be copied as long as it's made relevant to meters. <MarkMccarthy> Jemma: oaky <MarkMccarthy> s/oaky/okay <MarkMccarthy> Matt_King: and needs to be alphabetical, so it'd come before progressbar and after valuetext <MarkMccarthy> Matt_King: there's a branch here you can use, too. no worries <MarkMccarthy> Jemma: got it <MarkMccarthy> Matt_King: any other comments? I'd like folx to read this in the coming week. i'll work w/ you on final edits Jemma. I'd like to merge this next week if possible. <MarkMccarthy> Matt_King: if there's common questions we haven't answered; issues authors run into commonly; other things that aren't addressed well or at all; all good to know. <MarkMccarthy> Matt_King: jongund, have you read that yet? <MarkMccarthy> jongund: looking at it now <MarkMccarthy> Matt_King: you're probably someone who's very in touch with people who stumble <MarkMccarthy> jongund: i stumble! [laughs] <MarkMccarthy> [group laughter] <MarkMccarthy> carmacleod: your resiliance is impressive, Jon! :) |
I like the table for default and required values, but I think it should also include aria-valuenow, and be formatted with two rows of headers to make it visually easier to read.
Including the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment about expanding the table of default and required values to include aria-valuenow
.
The table would be better in the previous section.
The example in 8.5 it would be good to include a comment in the sample code that the scrollbar is for showing more or less of the digits of the constant PI.
@a11ydoer, thank you for the meter section; it is looking good. @carmacleod, thank you for the suggestions; they are all good as well. I think the meter and spin button sections should have links back to the pattern like in slider. I am curious if others would like to see the table of requirements by role expanded to include valuenow as Jon has suggested? I don't recall if there is a default calculation of valuenow for any of these roles. If not, we may not want a default column for valuenow. However, we could certainly have a required yes/no column for it. |
Yes, I think that would make things clearer, and all in one place.
I believe the only role that doesn't require valuenow is spinbutton. |
@mcking65 The latest commit does the following:
@jnurthen - ping on w3c/aria#1129 for 1.2 so that APG and ARIA 1.2 are in sync |
The table is correct - I triple-checked when I modified it. Agree that the prose does need to be updated in places to match the table. Looking at the table again now, though, I wonder if it would be clearer to delete the 3 "Required" columns, and instead, just use the word "Required" in the valuenow cells, maybe with an asterisk footnote below the table reminding authors that they need to provide a value. I also wonder if we should have 2 rows for progressbar (one for indeterminate), or maybe use another asterisk footnote to explain that a value is needed unless it's indeterminate? Similarly, spinbutton needs valuenow set if it has a value, so maybe we should point that out? For example, the "Default Values Table" could be rewritten like this:
Do people think this is clearer or more complicated? (note that it does contain more information in 4 columns than the current table contains in 7 columns...) |
How about something like this:
|
I like @jongund's latest table, except that I think the columns for aria-valuemin (required) and aria-valuemax (required) add complexity that is not strictly necessary, and could be confusing. Can we delete those two columns? I think authors know that if they don't want an attribute's default value, they need to set it to something else. Not sure if "current value" for valuenow might be confusing? i.e. could be confused as follows: |
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<carmacleod> TOPIC: Guidance on range-related properties<carmacleod> github: https://github.com//pull/1279 <carmacleod> mck: we are really close on this - need to make descriptions line up with info in table <carmacleod> mck: maybe change "current value" to "yes" (i.e. for "required - yes") <carmacleod> jongund: I updated the table to have "Yes" |
To wrap this up, we need commits to this branch that:
|
@jongund @mcking65 @carmacleod I created PR for the range related property. I appreciate if you can have a look for final feeback. Thanks, Jemma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change 1
"The meter role has the default value 0 for aria-valuemin, 100 for aria-valuemax. When the meter role does not provide default range values from 0 to 100, aria-valuemin and aria-valuemax property values are required. Also aria-valuenow range property is required for meter. Detailed description of the meter role can be found in the meter design pattern. "
I think the statements of defining the minimum and maximum values should be the similar for all the range related roles.
I suggest some changes to the second and third sentences:
The meter role has the default values 0 for aria-valuemin
and 100 for aria-valuemax
and only need to be set when the actual minimum and maximum values are different. The aria-valuenow
property is required for meter and the author needs to make sure aria-valuenow
is within the minimum and maximum values . Detailed description of the meter role can be found in the meter design pattern. "
Change 2
Most of the examples set the aria-valuemin
and aria-valuemax
to the default values, wouldn't it be better in these examples to eliminate setting them and have a comment that says the values are using the default values of 0 and 100.
<span id="cpu_usage_label">CPU usage</span>
<div role="meter"
// The CPU usage uses the default values of 0 and 100 for aria-valuemin and aria-valumax
aria-valuenow="90"
aria-labelledby="cpu_usage_label">
</div>
For the meter role we could have an additional code example using a different range, for example a PH meter.
<span id="ph_meter_label">PH</span>
<div role="meter"
aria-valuenow="1"
aria-valuemin="7"
aria-valuemax="14"
aria-labelledby="ph_meter_label">
</div>
454b04d
to
864db2b
Compare
@jongund, @a11ydoer, @carmacleod, I've completed final editorial review and revisions. I believe this is ready to merge. However, I'd like to have some approving reviews, especially from Jon since your last review was requesting changes before merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to request changes, but there are 3 code examples (progressbar, 2 spinbutton) where a required label is missing.
There's also 1 place (scrollbar) where a discretionary label might be useful (need a second opinion on that one).
And there's an editorial nit (missing "a").
Other than that, this looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In section 8.7 there is the following statement:
"If there are minimum and maximum allowed values, set the aria-valuemin and aria-valuemax properties."
What should be done if there is no minimum or maximum values?
Omitting the attributes gives you the default values of 0 and/or 100.
Are progress bars the only widget that can be indeterminate, it is the only one mentioned in the ARIA Spec?
If so maybe all the information related to indeterminate state should be moved to the progress bar section and removed form the other sections of the range widget.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the Section 8.1 on range guidance there seems to be a disconnect for ranges that are indeterminate and using default values for range attributes. The guidance for indeterminate is to not include aria-valuemax or aria-valuemin, but we also say when one or both of these attributed are not included that the default values of 0 and 100 will be used. So which is it, default values or indeterminate? Maybe it should be when the aria-valuenow attribute is missing or empty it should be the way to author identifies an indeterminate state.
@jongund wrote:
Section 8.7 says:
@jongund wrote:
Section 8.4 is about progressbar, and it says the following:
So, while the current value may be indeterminate, the limits of the range are never indeterminate. There are only 2 uses of the word "indeterminate", and both are in the progressbar section. |
Co-authored-by: Carolyn MacLeod <[email protected]>
@jongund wrote:
The only widget that allows for unknown range is spinbutton. Even a progressbar that is indeterminate must have known limits. I reworded section 8.1 in commit 1985db4 to clarify. I hope this addresses your concern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to merge now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Add guidance section for range related properties (pull #1279) Resolves issue #255 by adding a section That describes how to use aria-valuemin, aria-valuemax, aria-valuenow, and aria-valuetext. Co-authored-by: Valerie R Young <[email protected]> Co-authored-by: Matt King <[email protected]> Co-authored-by: Carolyn MacLeod <[email protected]> Co-authored-by: JaEun Jemma Ku <[email protected]>
Replaces #1000, changed to be a branch in this repo so it's easier to collaborate.
Preview Link
View the new section the compare branch using RawGitHack
Preview | Diff