Navigation menubar: Fix scroll-to-top problem reported in issue #1307 #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcking65
changed the title
spectranaut
reviewed
Jan 27, 2020
spectranaut
requested changes
Jan 27, 2020
There was a problem hiding this comment.
This change doesn't need or effect existing tests, so the "test review" can be marked as complete. As soon as I understand the necessity of the if (this.popupMenu) I'll approve it.
Thanks for fixing this bug, @carmacleod!
smhigley
approved these changes
Jan 28, 2020
|
@spectranaut |
spectranaut
approved these changes
Jan 28, 2020
michael-n-cooper
pushed a commit
that referenced
this pull request
Feb 5, 2020
Navigation menubar: Fix scroll-to-top problem for issue 1307 (pull #1308) Issue #1307 reported 2 problems with the navigation menubar example. This commit resolves the scroll to top issue by preventing menuitem anchor elements from jumping to href="#" (i.e. top of page in Chrome) if they have a menu/submenu. Co-authored-by: Matt King <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1307 reports 2 issues with the navigation menubar example. This PR resolves the scroll to top issue by preventing
menuitemanchor elements from jumping tohref="#"(i.e. top of page in Chrome) if they have a menu/submenu.Here's a preview link.
Review checklist