Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update menubutton examples: High Contrast Support and APG Coding Practices #1401

Merged
merged 61 commits into from
Nov 10, 2020
Merged

Update menubutton examples: High Contrast Support and APG Coding Practices #1401

merged 61 commits into from
Nov 10, 2020

Conversation

jongund
Copy link
Contributor

@jongund jongund commented May 12, 2020 •
edited by mcking65
Loading

Updated menu button examples to:

  1. Improve Javascript coding and use key rather than keyCode in keyboard events, and a single object
  2. Improved high contrast support

Preview links

Review: Menu Button for Links
Review: Menu Button for Actions
Review: Menu Button for Actions using aria-activedescendant

Review checklist

@jongund
Copy link
Contributor Author

jongund commented May 12, 2020

@zcorpan

Can you look at the test cases that are failing for the updated menu button examples?
I can't figure out why they are failing, I get passing results for most of the tests and inconsistent failures on my local MacOS and Windows 10 machine.

  1. macOS: links and aria-activedescent example all tests pass, page down, page up and end fail for actions with focus example.
  2. Windows 10: both action examples pass and there about six failures related to keystrokes for the links example.

This is driving me nuts, what don't I understand about the testing framework?

@jongund jongund mentioned this pull request Jul 14, 2020
Closed
@jongund jongund linked an issue Aug 4, 2020 that may be closed by this pull request
Update menu button examples to improve high contrast support and js practices #1399
Closed
@jongund jongund changed the title Issue1399 menubutton updates Update menubutton examples: High Contrast Support and APG Coding Practices Aug 4, 2020
@spectranaut
Copy link
Contributor

spectranaut commented Oct 22, 2020 •
edited
Loading

All conflicts were related to new lint and prettier rules! Fixed now :)

@spectranaut spectranaut force-pushed the issue1399-menubutton-updates branch from f666e9d to 61a2ade Compare October 22, 2020 18:00
@jongund
Copy link
Contributor Author

jongund commented Oct 25, 2020

@mcking65
Javascript now uses class instead of prototype for defining widget object inline with new authoring practices.

@jongund
Copy link
Contributor Author

jongund commented Oct 27, 2020

@mcking65
I have updated the high contrast documentation.

@mcking65
Copy link
Contributor

mcking65 commented Nov 9, 2020

As anticipated, we have some conflicts from recent merges. @jongund, if you could help resolve, that'd be great. Otherwise, Valerie can help when she has another day on APG.

This looks pretty much ready to go. I want to make some minor grammar edits to the accessibility features documentation. Then, I'll merge.

nschonni
nschonni reviewed Nov 9, 2020
View reviewed changes
examples/menu-button/menu-button-actions-active-descendant.html
<li>Javascript: <a href="js/PopupMenuActionActivedescendant.js" type="text/javascript">PopupMenuActionActivedescendant.js</a></li>
</ul>
<li>CSS: <a href="css/menu-button-actions.css" type="text/css">menu-button-actions.css</a></li>
<li>Javascript: <a href="js/menu-button-actions-active-descendant.js" type="text/javascript">menu-button-actions-active-descendant.js</a>
</section>

This comment was marked as outdated.

Sign in to view

@jongund
Copy link
Contributor Author

jongund commented Nov 9, 2020

@mcking65
I fixed the conflicts, so should be ready for your edits.

mcking65
mcking65 approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial review complete; ready to merge!

@mcking65
Copy link
Contributor

@jongund thank you, thank you, thank you for all the hard work put into this!!!!

@mcking65 mcking65 merged commit 243f77d into master Nov 10, 2020
@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern labels Nov 10, 2020
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Nov 10, 2020
@mcking65 mcking65 deleted the issue1399-menubutton-updates branch November 10, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nschonni nschonni nschonni left review comments

@curtbellew curtbellew curtbellew approved these changes

@charmarkk charmarkk charmarkk approved these changes

@mcking65 mcking65 mcking65 approved these changes

@carmacleod carmacleod carmacleod approved these changes

@spectranaut spectranaut spectranaut approved these changes

Assignees
No one assigned
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Projects
Command, Toggle, Menu, and Disclosure Button Patterns and Examples Development Project
Status: Next Steps
Milestone
1.2 Release 1
Development

Successfully merging this pull request may close these issues.

Update menu button examples to improve high contrast support and js practices
7 participants
@jongund @mcking65 @spectranaut @carmacleod @charmarkk @nschonni @curtbellew