-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infrastructure: Add Prettier ESLint config #1553
Conversation
|
.prettierrc
Outdated
@@ -0,0 +1,3 @@ | |||
{ | |||
"singleQuote": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seemed to be the more common pattern so I used this over the default double quote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great too!
After this merges @jongund, npm run lint:es
will fail on a lot more things related to coding style -- but you can fix all of these failures by running npm run fix
. It will break long lines up into multiple lines and switch double quotes with single quotes and other things like this. You will probably have to run npm run fix
on all your open PRs once this merges.
Use the default settings and tie it to the current ESLint setup
ab999d4
to
ed56e18
Compare
Related to #1180
Kept the the defaults, except for the quoting, that seems primarily single quotes