Infrastructure: Fix previously excluded ESLint issues

[nschonni]

Built off of #1602, then when through and addressed the missing/undefined variable issues by example

[github-actions]

Regression test coverage:

Examples without any regression tests:

• dialog-modal/alertdialog.html

Examples missing some regression tests:

• dialog-modal/datepicker-dialog.html:
  • textbox-aria-describedby
• menu-button/menu-button-actions-active-descendant.html:
  • menu-up-arrow
  • menu-down-arrow
  • menu-character
• toolbar/toolbar.html:
  • toolbar-tab
  • toolbar-right-arrow
  • toolbar-left-arrow
  • toolbar-home
  • toolbar-end
  • toolbar-toggle-esc
  • toolbar-toggle-enter-or-space
  • toolbar-radio-enter-or-space
  • toolbar-radio-down-arrow
  • toolbar-radio-up-arrow
  • toolbar-button-enter-or-space
  • toolbar-menubutton-enter-or-space-or-down-or-up
  • toolbar-menu-enter-or-space
  • toolbar-menu-down-arrow
  • toolbar-menu-up-arrow
  • toolbar-menu-escape
  • toolbar-spinbutton-down-arrow
  • toolbar-spinbutton-up-arrow
  • toolbar-spinbutton-page-down
  • toolbar-spinbutton-page-up
  • toolbar-checkbox-space
  • toolbar-link-enter-or-space
  • toolbar-spinbutton-role

Example pages with Keyboard or Attribute table rows that do not have data-test-ids:

• dialog-modal/alertdialog.html
  • "Keyboard Support" table(s):
    • Tab
    • Shift + Tab
    • Escape
    • Command + S
    • Control + S
  • "Attributes" table(s):
    • alertdialog
    • aria-labelledby=IDREF
    • aria-describedby=IDREF
    • aria-modal=true
    • alert

SUMMARY:

55 example pages found.
1 example pages have no regression tests.
3 example pages are missing approximately 27 out of approximately 780 tests.

ERROR - missing tests:

Please write missing tests for this report to pass.

[nschonni]

@jongund even if this doesn't land, there might be a few bits to apply to your in-progress PRs

[spectranaut]

I'm in favor of this change and it all looks good, thanks so much to getting to this work, @nschonni. Just curious, did you use a tool to clean these up?

[nschonni]

I don't think much of this was auto-fixable. I think I probably just manually cleaned it up while I was trying to distract my brain

[spectranaut]

@nschonni If there was a tool I wanted to know about it :) I really appreciate the work!

[mcking65]

@nschonni
Sorry, think #1623 resulted in conflicts. When you get a chance, could you please rebase?

[nschonni]

@mcking65 no problem, it was based on that other PR, but I guess got out of sync. I've rebased this one now

[mcking65]

@nschonni
I should have merged right after you last rebased ... sorry. So, I updated the branch and surprised to see some failing tests.

[mcking65]

@nschonni
Just after merging this, regression started failing again for the spinbutton increment/decrement tests in #1712. I don't understand how that is possible since that testing passed for this PR. Maybe unrelated? Maybe related? Confused.

[nschonni]

Not related to this, I think it's hitting another issue related to the new year. EX: it also failed on PRs yesterday https://github.com/w3c/aria-practices/runs/1661714101?check_suite_focus=true

[nschonni]

I fixed it in e4e0cf7 as part of the larger #1640, but I can split that out if you want a quicker PR to get stuff green again