Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orange box style for the cautionary note #1643

Merged
merged 3 commits into from
Dec 3, 2020

Conversation

carmacleod
Copy link
Contributor

Wrap caution paragraph/list in a div with w3c "advisement" class, which gives the div a light orange background with a darker orange border on the left.

@carmacleod carmacleod requested a review from jongund December 1, 2020 22:10
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2020

Regression test coverage:

Examples without any regression tests:

  • dialog-modal/alertdialog.html

Examples missing some regression tests:

  • dialog-modal/datepicker-dialog.html:
    • textbox-aria-describedby
  • menu-button/menu-button-actions-active-descendant.html:
    • menu-up-arrow
    • menu-down-arrow
    • menu-character
  • toolbar/toolbar.html:
    • toolbar-tab
    • toolbar-right-arrow
    • toolbar-left-arrow
    • toolbar-home
    • toolbar-end
    • toolbar-toggle-esc
    • toolbar-toggle-enter-or-space
    • toolbar-radio-enter-or-space
    • toolbar-radio-down-arrow
    • toolbar-radio-up-arrow
    • toolbar-button-enter-or-space
    • toolbar-menubutton-enter-or-space-or-down-or-up
    • toolbar-menu-enter-or-space
    • toolbar-menu-down-arrow
    • toolbar-menu-up-arrow
    • toolbar-menu-escape
    • toolbar-spinbutton-down-arrow
    • toolbar-spinbutton-up-arrow
    • toolbar-spinbutton-page-down
    • toolbar-spinbutton-page-up
    • toolbar-checkbox-space
    • toolbar-link-enter-or-space
    • toolbar-spinbutton-role

Example pages with Keyboard or Attribute table rows that do not have data-test-ids:

  • dialog-modal/alertdialog.html
    • "Keyboard Support" table(s):
      • Tab
      • Shift + Tab
      • Escape
      • Command + S
      • Control + S
    • "Attributes" table(s):
      • alertdialog
      • aria-labelledby=IDREF
      • aria-describedby=IDREF
      • aria-modal=true
      • alert

SUMMARY:

54 example pages found.
1 example pages have no regression tests.
3 example pages are missing approximately 27 out of approximately 769 tests.

ERROR - missing tests:

Please write missing tests for this report to pass.

@carmacleod
Copy link
Contributor Author

carmacleod commented Dec 1, 2020

Urgh. Apparently we're not allowed to override w3c styles. :(
(It worked locally).

The regression test failure is for "down arrow on day" which is being fixed in #1640 and/or #1639.

@carmacleod
Copy link
Contributor Author

Ok, I took out my css override and opened issue https://github.com/w3c/respec/issues/3233.
So for now we'll have to live with the inconsistent-looking right border in the orange box.

Everything is passing now except for the "down arrow on day" regression test mentioned above, so I think this is good to go.

@mcking65
Copy link
Contributor

mcking65 commented Dec 3, 2020

interesting, I was unaware of the advisement class ... is that in the tr 2016 base css?

@mcking65 mcking65 merged commit 02a7fd7 into update-tree-nav Dec 3, 2020
@mcking65 mcking65 deleted the car/orange-caution-box branch December 3, 2020 03:49
@carmacleod
Copy link
Contributor Author

interesting, I was unaware of the advisement class ... is that in the tr 2016 base css?

I think so. The respec people asked me to open my right border in advisement style is inconsistent issue over in the tr-design repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants