Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: Add newline at EOF when generating example index #1669

Merged
merged 2 commits into from
Dec 22, 2020

Conversation

nschonni
Copy link
Contributor

No description provided.

@nschonni
Copy link
Contributor Author

@mcking65 this should fix the generation job issue

This was referenced Dec 14, 2020
@nschonni nschonni force-pushed the newline-index-generation branch from e27b974 to 1185a3f Compare December 14, 2020 04:58
@nschonni
Copy link
Contributor Author

@mcking65 this will revert your change from #1670 because manually editing the index file with an editor with EditorConfig will add the newline.

Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@mcking65
Copy link
Contributor

@nschonni
I never touched the index file with an editor. I think the package we have that auto-enforces the editorconfig on commit must have done that.

@nschonni
Copy link
Contributor Author

@mcking65 you fix definitely works and unblocked the failing CI. This way of updating the template script and adding back the trailing newline just allows people to manually edit the file in addition to using the generation script, depending on their setup.

Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nschonni.

@mcking65 mcking65 changed the title fix: Add newline at EOF for example generation Infrastructure: Add newline at EOF when generating example index Dec 22, 2020
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation labels Dec 22, 2020
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Dec 22, 2020
@mcking65 mcking65 merged commit d15cfc7 into w3c:master Dec 22, 2020
@nschonni nschonni deleted the newline-index-generation branch December 22, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code defects; not for inaccurate prose Infrastructure Related to maintaining task force and repo operations, processes, systems, documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants