Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guidance section about Communicating Widget States #2071

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Oct 27, 2021

Replaces #1277


Preview | Diff

aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
@zcorpan zcorpan added this to the 1.2 Release 1 milestone Oct 29, 2021
@zcorpan
Copy link
Member Author

zcorpan commented Oct 29, 2021

I have now addressed the review comments. Please take a look. 🙂

@mcking65
Copy link
Contributor

There has been a lot of confusion about several of these properties, especially checked and selected. ARIA issues on this topic are some of the most commented. This is one of those topics where the spec language and its implications are particularly challenging for most people to groc, so it is important for APG to make it concrete and understandable. To do that, we need to add some more guidance with specific examples explaining the nuances of the spec.

Even though some of the spec language that supports greater clarity didn't make it into 1.2 and is only now in the editor's draft for 1.3, the updates have already been made to browsers. So, our first release of this section should reflect that reality.

In particular, we need to include thorough explanations of the language regarding checked and selected in option and treeitem added in ARIA PR 1340. The history and comments in that PR are helpful context.

One of the concepts we considered working into the spec as a requirement but instead left as a non-normative sentence is the preference for checked in multi-selects and selected in single selects. We decided that it is more appropriate at this time for the APG to provide more definitive guidance.

Another topic that needs to be clarified in this section or referenced where appropriate is the difference between focus and selection and the meaning of selection following focus. We might be able to do this more effectively if we first update the keyboard design section on selection and focus. I'm not sure where the best place to define the difference is; it might be this section. However, the keyboard section currently does not reference any of the completed examples that demonstrate the difference well, e.g., tabs. I think it was written before they existed.

@zcorpan
Copy link
Member Author

zcorpan commented Nov 2, 2021

@mcking65 that's a lot of context... Can you suggest the text you'd like to see added or changed?

Do we need to fix the focus/selection clarification in this PR?

@a11ydoer can we add this to the agenda for today?

@zcorpan zcorpan added the agenda Include in upcoming Authoring Practices Task Force meeting label Nov 2, 2021
@zcorpan
Copy link
Member Author

zcorpan commented Nov 2, 2021

@mcking65 said in today's meeting:

  • shouldn't say that aria-selected is required
  • should clarify focus vs selection
  • should link to selection follows focus

@a11ydoer
Copy link
Contributor

a11ydoer commented Nov 2, 2021

General editorial idea - adding section about "selected" and connecting with keyboard section regarding focus management

@a11ydoer a11ydoer removed the agenda Include in upcoming Authoring Practices Task Force meeting label Jan 18, 2022
@mcking65 mcking65 removed this from the 1.2 Release 1 milestone May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants