Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: Fix report.js unsupported buffer #2151

Merged
merged 2 commits into from
Nov 22, 2021

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Nov 19, 2021

Relevant to address an issue found when running the npm run regression-report command

#959 (comment)

$ npm run regression-report

> [email protected] regression-report
> node test/util/report

Z:\aria-practices\node_modules\htmlparser2\lib\Tokenizer.js:628
            var c = this.buffer.charCodeAt(this._index);
                                ^

TypeError: this.buffer.charCodeAt is not a function
    at Tokenizer.parse (Z:\aria-practices\node_modules\htmlparser2\lib\Tokenizer.js:628:33)
    at Tokenizer.write (Z:\aria-practices\node_modules\htmlparser2\lib\Tokenizer.js:111:14)
    at Tokenizer.end (Z:\aria-practices\node_modules\htmlparser2\lib\Tokenizer.js:117:18)
    at Parser.end (Z:\aria-practices\node_modules\htmlparser2\lib\Parser.js:390:24)
    at parseDocument (Z:\aria-practices\node_modules\htmlparser2\lib\index.js:43:43)
    at Object.parseDOM (Z:\aria-practices\node_modules\htmlparser2\lib\index.js:58:12)
    at processDocumentationInExampleFiles (Z:\aria-practices\test\util\report.js:112:29)
    at Object.<anonymous> (Z:\aria-practices\test\util\report.js:214:1)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)

@howard-e howard-e merged commit 8aee856 into main Nov 22, 2021
@howard-e howard-e deleted the bocoup/update-regression-report branch November 22, 2021 18:54
michael-n-cooper pushed a commit that referenced this pull request May 9, 2022
Update test/util/report.js to fix an issue discovered in #959. Buffers being passed to `htmlparser2.parseDocument` is unsupported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants