Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AT support tables to example pages for alert, link, and radio using activedescendant #2653

Merged
merged 2 commits into from
Mar 31, 2023

Conversation

mcking65
Copy link
Contributor

@mcking65 mcking65 commented Mar 30, 2023

Updates three example pages to include a section for AT support:

  • Alert
  • Link
  • Radio Using aria-activedescendant

WAI Preview Link (Last built on Thu, 30 Mar 2023 19:05:07 GMT).

@mcking65
Copy link
Contributor Author

@alflennik , please fix the code so the tables display.

In #2569, I had aked why we had a class specific to each ifram, e.g., class="support-levels-toggle-button". and where these classes are defined. Is this necessary? Can't we have a single "at-support-table" class?

I guessed at the parameter values and got it right for alert but wrong for link and radio. We need a way to get rid of the guessing.

@alflennik
Copy link
Contributor

Hi @mcking65, the slug-style names originate here in the aria-at repo, so for link, the link-span-text name is the one to use, and for radio the name in question is radiogroup-aria-activedescendant. The reason there are unique class names for each iframe is that message-passing script which fixes the iframe heights when the iframe height changes (like on page resize or when the details box opens and closes) needs a way to uniquely refer to the iframes when there are multiple instances on the page at once. I think in the near-to-medium-term future, both of these irritations will be resolved by having a "copy embed code" button directly in the aria-at-app. Hopefully that helps. I'll update the code in this PR to use the accurate names.

Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see more ARIA-AT data in the APG! I tested and they work well.

@mcking65
Copy link
Contributor Author

Thank you @alflennik for the helpful info, speedy fix, and review! I understand a little better how it works now, and it's easy enough for me to add the iframes to additional pages as needed.

@mcking65 mcking65 merged commit 4f1d770 into main Mar 31, 2023
@mcking65 mcking65 deleted the additional-support-tables branch March 31, 2023 00:40
@mcking65 mcking65 added enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy documentation labels Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants