Navigation Menubar Example: Remove second example with dynamically added ARIA attributes #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jongund, I will put this on agenda for Monday. We want labels on the menu elements, but it looks like they are in the HTML source so the js you are removing does nothing. Example 2 states that the ARIA is not in the HTML, but it actually is. I am thinking we should consider removing the second menubar example that is on the same page ... it may be more distracting than valuable ... and permits simplification of the js. |
jongund
changed the title
jongund
changed the title
jongund
changed the title
|
@jongund, thank you, thank you! Much cleaner. Note: I pushed a commit to your fork that removed a few more vestages of the second example. |
mcking65
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug fixes a problem in the source code view and I don't think we needed a label for the role=menu or a tabindex=-1 on the menu role