Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fallback table #1208

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Update fallback table #1208

merged 2 commits into from
Mar 11, 2020

Conversation

carmacleod
Copy link
Contributor

@carmacleod carmacleod commented Feb 29, 2020

Resolves #1206


Preview | Diff

Copy link
Member

@scottaohara scottaohara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

index.html Outdated Show resolved Hide resolved
…lbar and slider.

Also:
- add missing </div>
- fix broken link to (missing #) authorErrorDefaultValuesTable
- remove 2 extraneous class="specref" in #authorErrorDefaultValuesTable links
@carmacleod
Copy link
Contributor Author

@jnurthen This PR is ready for final review.

@jnurthen jnurthen requested a review from schne324 March 5, 2020 18:22
Copy link
Contributor

@schne324 schne324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jnurthen jnurthen merged commit 9c73b5b into master Mar 11, 2020
carmacleod added a commit that referenced this pull request May 7, 2020
@jnurthen jnurthen deleted the issue1206 branch July 23, 2020 22:27
jnurthen pushed a commit that referenced this pull request Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fallback table for required attribute values needs updating
4 participants