[cssom-view-1] Add container option to scrollIntoView options. #11673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the container option to ScrollIntoViewOptions allowing scrolling only the nearest containing scrolling box as resolved in w3c#9452.
tabatkins
reviewed
Feb 7, 2025
This was referenced Feb 7, 2025
Closed
1 task
AtkinsSJ
reviewed
Feb 12, 2025
Comment on lines
+1302
to
+1303
| 1. If the {{ScrollIntoViewOptions/container}} dictionary member of <var>options</var>, | ||
| set <var>container</var> to this element. |
There was a problem hiding this comment.
I think this is missing some words.
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Feb 12, 2025
Corresponds to w3c/csswg-drafts#11673 , with the addition of the fixes in w3c/csswg-drafts#11701
kalenikaliaksandr
pushed a commit
to LadybirdBrowser/ladybird
that referenced
this pull request
Feb 12, 2025
Corresponds to w3c/csswg-drafts#11673 , with the addition of the fixes in w3c/csswg-drafts#11701
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the container option to ScrollIntoViewOptions allowing scrolling only the nearest containing scrolling box as resolved in #9452. This also sets us the algorithm to scroll an element into view for scroll markers #11138.