Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mark mapping to core aam #365

Merged
merged 3 commits into from
Feb 6, 2022
Merged

update mark mapping to core aam #365

merged 3 commits into from
Feb 6, 2022

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Jan 23, 2022 •
edited by pr-preview bot
Loading

core aam has the mark role defined. So HTML AAM can point to that instead of having it here.

closes #316

Preview | Diff

@scottaohara
update mark mapping to core aam
b3bc1fc 
core aam has the `mark` role defined.  So HTML AAM can point to that instead of having it here.

closes #316
smhigley
smhigley reviewed Jan 27, 2022
View reviewed changes
Copy link

@smhigley smhigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the core-aam mappings for role=mark are different from the html-aam mappings for the mark element. Do we know which are actually correct?

@scottaohara
Copy link
Member Author

Core AAM is the latest mappings for the role

@scottaohara scottaohara merged commit 5d42f43 into gh-pages Feb 6, 2022
@scottaohara scottaohara deleted the mark-role branch February 6, 2022 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smhigley smhigley smhigley left review comments

@carmacleod carmacleod carmacleod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mark role
3 participants
@scottaohara @carmacleod @smhigley