Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colour in images, fix #374 #459

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Colour in images, fix #374 #459

merged 2 commits into from
Jul 15, 2024

Conversation

svgeesus
Copy link
Contributor

An earlier pull request changed human-visible colour to color in index.html {preserving second edition links that use colour)
https://github.com/w3c/PNG-spec/pull/411/files

However:

  • the svg images still used the colour spelling
  • a couple more usages of colour have crept back since

Now fixed by this PR.

Also, the change log about private color type values could have been read as a new feature; I reworded it to be a clarification.

@svgeesus svgeesus requested review from chrisn and ProgramMax July 15, 2024 14:54
Copy link
Member

@chrisn chrisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@svgeesus svgeesus merged commit 13f72b7 into main Jul 15, 2024
1 check passed
@svgeesus svgeesus deleted the colour-in-images-374 branch July 15, 2024 15:19
@ProgramMax
Copy link
Collaborator

I thought we were supposed to use international English's "colour".

@chrisn
Copy link
Member

chrisn commented Jul 15, 2024

In #374 we made the spec use US English more consistently, following the W3C style guide.

@ProgramMax
Copy link
Collaborator

Huh. Yeah.
"The working language of W3C is American English." - https://www.w3.org/Consortium/Translation/

I could have sworn it was international English before. Maybe this changed and I missed it. Or maybe I'm misremembering. Either way, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants