This repository has been archived by the owner on May 5, 2022. It is now read-only.
Preload + SRI compatibility #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
yoavweiss
reviewed
Jun 20, 2019
index.html
Outdated
| <p>Once a <dfn>preload resource has been obtained</dfn>, the user agent | ||
| must add request to fetch group's response cache.</p> | ||
| <p>Once a preload resource <a data-cite="!HTML#process-the-linked-resource">has been processed</a>, | ||
| the user agent must add the response to the fetch group's response cache. The user agent |
There was a problem hiding this comment.
I'm not sure when the "fetch group's response cache" phrasing was added, but I don't think it's a thing nowadays...
@igrigorik - do you happen to remember?
Maybe it would be better to make it explicitly vague in the meantime until we define a proper preload cache, and just call it "cache"?
There was a problem hiding this comment.
I'd be ok with that, though I think I'd prefer the term "preload cache" since I feel it'd be good to distinguish it from the HTTP cache while the preload cache isn't fully specified. Do you have a preference? (Regardless, yeah I'm not sure what "fetch group's response cache is").
yoavweiss
approved these changes
Jun 20, 2019
|
Should be all good to go |
yoavweiss
approved these changes
Jun 21, 2019
|
Thanks! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the compatibility between link
rel=preloaddefined in the specification, and subresource integrity defined in SRI as much as it can, before the preload cache infrastructure is fully-specified (discussed here).Corresponding HTML Standard change: whatwg/html#4699 (I think we should block merging this until the HTML PR lands).
/cc @kinu @nyaxt @yutakahirano
Closes #127
Preview | Diff