Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts and Graphs ONIX metadata #283

Closed
clapierre opened this issue May 21, 2024 · 9 comments
Closed

Charts and Graphs ONIX metadata #283

clapierre opened this issue May 21, 2024 · 9 comments

Comments

@clapierre
Copy link
Collaborator

I am concerned that ONIX technique's instructions for Chart's and Graphs is slightly incorrect.

If there are No chart's and graphs in the EPUB but there are Images with Long descriptions or alt text

You will get displayed "Charts and diagrams have extended descriptions" OR "Visualised data also available as non-graphical data"

We should also change the spelling to be "Visualized" with a z

I would think that we should add

IF contains_charts_diagrams AND charts_diagrams_diagrams_as_long_text
...
IF contains_charts_diagrams AND charts_diagrams_as_non_graphical_data
...

@GeorgeKerscher
Copy link
Collaborator

I commented on Charles PR on this topic in the EPUB Accessibility techniques.

Essentially, when Chem on Visual is present, there are three ways to make it accessible:

ChemML is already identified, but we do not know if it works.
Long descriptsions could be used.
There is now Chemistry in MathML.

There is the Chemistry on the Web and in Publishing we might turn to for guidance.

@gautierchomel
Copy link
Collaborator

IF contains_charts_diagrams AND charts_diagrams_diagrams_as_long_text
IF contains_charts_diagrams AND charts_diagrams_as_non_graphical_data

Where should we add that?

@gautierchomel
Copy link
Collaborator

gautierchomel commented May 23, 2024

We should also change the spelling to be "Visualized" with a z

Done in #288.

Shouldn't we then define lang="en-US" xml:lang="en-US"?

@GeorgeKerscher
Copy link
Collaborator

I copied the whole of the principles and copied it into Word and did a spell and grammar check. I think there are about a dozen suggested changes I should make. Also, I see that the Ruby specification calls it Ruby markup, not Ruby annotations, so that should change as well. This would mean a lot of changes sprinkled throughout the document.

@clapierre
Copy link
Collaborator Author

clapierre commented May 23, 2024

IF contains_charts_diagrams AND charts_diagrams_diagrams_as_long_text
IF contains_charts_diagrams AND charts_diagrams_as_non_graphical_data

Where should we add that?

Adding "contains_charts_diagrams AND" should be part of the 4.6.3 Instructions 1 & 2

@gautierchomel
Copy link
Collaborator

Shouldn't we then define lang="en-US" xml:lang="en-US"?

@mattgarrish, @iherman ?

@iherman
Copy link
Member

iherman commented May 23, 2024

Shouldn't we then define lang="en-US" xml:lang="en-US"?

@mattgarrish, @iherman ?

You mean in the html element at the top of the file (instead of just 'en')? Yes, strictly speaking, this should be done, because W3C publication rules require US English. I am not sure that we did that systematically in our documents. @mattgarrish ?

@iherman
Copy link
Member

iherman commented May 23, 2024

Shouldn't we then define lang="en-US" xml:lang="en-US"?

@mattgarrish, @iherman ?

You mean in the html element at the top of the file (instead of just 'en')? Yes, strictly speaking, this should be done, because W3C publication rules require US English. I am not sure that we did that systematically in our documents. @mattgarrish ?

I just checked our core specifications and yes, it is systematically set. So yes, @gautierchomel, this should be done.

gautierchomel added a commit that referenced this issue May 24, 2024
As per #283 adds a check in the instructions to make sure that If there are No chart's and graphs in the EPUB but there are Images with Long descriptions or alt text, we do not end up with displayed "Charts and diagrams have extended descriptions".
gautierchomel added a commit that referenced this issue May 24, 2024
As per #291 originaly discussed in #283 (comment)

Applies only to Display Guide and Techniques drafts.
@gautierchomel
Copy link
Collaborator

gautierchomel commented May 24, 2024

IF contains_charts_diagrams AND charts_diagrams_diagrams_as_long_text
IF contains_charts_diagrams AND charts_diagrams_as_non_graphical_data
Adding "contains_charts_diagrams AND" should be part of the 4.6.3 Instructions 1 & 2

Agree (see proposal in #288)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants