Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch fixes #62

Merged
merged 58 commits into from
May 13, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
2b540f2
Add homepage
alflennik Mar 14, 2022
c8b3aa8
Set up homepage and address some feedback on it
alflennik Mar 17, 2022
11c93e2
Address internal feedback
alflennik Mar 21, 2022
caa9360
Address feedback items
alflennik May 3, 2022
c77e305
Address release feedback
alflennik May 4, 2022
d37d697
Addressing feedback
alflennik May 5, 2022
491a739
Address feedback
alflennik May 5, 2022
74c9513
Addressing feedback
alflennik May 9, 2022
9022935
Addressing feedback
alflennik May 9, 2022
54423df
Merge branch 'main' into launch-fixes
alflennik May 9, 2022
e4bdac8
Address feedback
alflennik May 9, 2022
a97f69a
Address issue 47
alflennik May 9, 2022
fe48946
Partially address issue 65
alflennik May 9, 2022
9071ea6
Add auto sidebar
SteveALee May 10, 2022
c3f30a1
Partially address issue 65
alflennik May 9, 2022
3e79ac0
Address issue 66
alflennik May 10, 2022
25d98b8
Address issue 55
alflennik May 10, 2022
f994d44
Add baseurl support to all pages except homepage
alflennik May 10, 2022
1b24e7b
Address issue 60
alflennik May 10, 2022
b559978
Fix build attempt 1
alflennik May 11, 2022
b6b45d2
Fix build attempt 2
alflennik May 11, 2022
d6b584d
Merge branch 'launch-fixes' into steve-add-sidebar
SteveALee May 11, 2022
a9033ea
Update netlify build command
SteveALee May 11, 2022
6b9c33f
Address issue#65 - Fix styling of H2 in Homepage
isaacdurazo May 11, 2022
e759eff
Merge branch 'main' into launch-fixes
alflennik May 11, 2022
764b9a5
Address issue #60 - Update h1 and title in Patterns page
isaacdurazo May 11, 2022
b36c943
Revert change
isaacdurazo May 11, 2022
5d5163f
Address issue #60 - Move Index between practices and about
isaacdurazo May 11, 2022
32f53cd
Address issue 76
alflennik May 11, 2022
4560802
Merge branch 'launch-fixes' of https://github.com/bocoup/wai-aria-pra…
alflennik May 11, 2022
0872041
Address issue 75 attempt 1
alflennik May 11, 2022
cda87dc
adjust config paths
howard-e May 11, 2022
b93e4e8
Address issue 53
alflennik May 11, 2022
a743b61
Test removing 'site.baseurl' constructed template url
howard-e May 11, 2022
b8b2e8b
test relative path on assets
howard-e May 11, 2022
d5863b7
Address issue 32 attempt 2
alflennik May 11, 2022
2826fb9
test with removing ../../../
howard-e May 11, 2022
9cb0dd7
Changed files
howard-e May 11, 2022
5f86eda
Undo issue 75 attempt 1
alflennik May 11, 2022
73a7f6f
adjust read-this-first path
howard-e May 11, 2022
4aae121
Address issue 74
alflennik May 12, 2022
b8fcd6a
Make tweak for issue 48
alflennik May 12, 2022
90708a9
Address issue 79
alflennik May 12, 2022
acc6643
Merge pull request #72 from w3c/steve-add-sidebar
alflennik May 12, 2022
edb5868
Address issue 24
alflennik May 12, 2022
2105102
Remove extra nav element from index
alflennik May 12, 2022
38621fc
Merge branch 'launch-fixes' into test-75
alflennik May 12, 2022
07bfc52
Address issue 75
alflennik May 12, 2022
4bfd41b
Fix index page in netlify
alflennik May 12, 2022
515f2a6
Address comments on issue 74
alflennik May 12, 2022
56c4529
Update APG content
alflennik May 12, 2022
f50d5ac
Add WAI permalink structure part 1 of 2
alflennik May 12, 2022
9af92de
Use lowercase URLs
alflennik May 12, 2022
c0dcbac
Update netlify build
SteveALee May 13, 2022
933c7c2
Update plugin from data submodule
SteveALee May 13, 2022
11e298a
Update wai data submodule with PR 87 merged
alflennik May 13, 2022
31d0e1b
Merge branch 'launch-fixes' of https://github.com/bocoup/wai-aria-pra…
alflennik May 13, 2022
108fa37
Merge branch 'main' into launch-fixes
alflennik May 13, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,3 @@ vendor
node_modules
.netlify
.bundle
landmarks
Original file line number Diff line number Diff line change
@@ -1,12 +1,21 @@
---
# This is a generated file
title: "Accordion Example"
ref: /aria-practices/
ref: /aria/apg/example-index/accordion/accordion

github:
repository: w3c/aria-practices
path: aria-practices.html
permalink: /index/accordion/accordion
branch: main
path: examples/accordion/accordion.html
feedbackmail: [email protected]
permalink: /aria/apg/example-index/accordion/accordion

sidebar: true

footer: " <div class='example-page-footer'> <p><a href='https://github.com/w3c/aria-practices/projects/8'>View issues related to this example</a></p> <p>Page last updated: November 23, 2021</p> </div> "

# Context here: https://github.com/w3c/wai-aria-practices/issues/31
type_of_guidance: APG

lang: en
---
Expand All @@ -17,62 +26,65 @@ lang: en
<link rel="stylesheet" type="text/css" href="css/accordion.css" />


<link rel="stylesheet" href="/assets/styles.css">
<link
rel="stylesheet"
href="{{ '/content-assets/wai-aria-practices/styles.css' | relative_url }}"
>
<!-- Code highlighting styles -->
<link rel="stylesheet" href="/index/css/github.css">
<link
rel="stylesheet"
href="{{ '/aria/apg/example-index/css/github.css' | relative_url }}"
>

<script>
const addBodyClass = undefined;
const enableSidebar = true;
if (addBodyClass) document.body.classList.add(addBodyClass);
if (enableSidebar) document.body.classList.add('has-sidebar');
</script>

<div>

<div class="sidebar-container">
<aside class="sidebar-left" aria-describedby="sidebar-toc">
<h2 id="sidebar-toc" class="sidebar-headline">Table of Contents</h2>
<ul class="sidebar-list">

<li>
<a href="#ex_label">Example</a>
</li>

<li>
<a href="#kbd_label">Keyboard Support</a>
</li>

<li>
<a href="#rps_label">Role, Property, State, and Tabindex Attributes</a>
</li>

<li>
<a href="#javascript-and-css-source-code">Javascript and CSS Source Code</a>
</li>

<li>
<a href="#sc1_label">HTML Source Code</a>
</li>

</ul>

<ul class="sidebar-list sidebar-list-yellow">
<li><a href="/about/#browser_and_AT_support">Browser and Assistive Technology Support</a></li>
<li><a href="https://github.com/w3c/aria-practices/issues/new">Report Issue</a></li>
<li><a href="https://github.com/w3c/aria-practices/projects/8">Related Issues</a></li>
<li><a href="/patterns/accordion/">Design Pattern</a></li>
<h2>About This Example</h2>
<details id="support-notice" class="note">
<summary>Important Note About Use of This Example</summary>
<p>
Note: This is an illustrative example of one way of using ARIA that conforms with the ARIA specification.
</p>
<ul>
<li>
There may be support gaps in some
<a href="{{ '/aria/apg/practices/read-me-first/#browser_and_AT_support' | relative_url }}">browser and assistive technology combinations</a>,
especially for <a href="{{ '/aria/apg/practices/read-me-first/#mobile_and_touch_support' | relative_url }}">mobile/touch devices</a>.
Testing code based on this example with assistive technologies is essential before considering use in production systems.
</li>
<li>
The <a href="https://aria-at.w3.org">ARIA and Assistive Technologies Project</a>
is developing measurements of assistive technology support for APG examples.
</li>
<li>
Robust accessibility can be further optimized by choosing implementation patterns that
<a href="https://www.w3.org/TR/using-aria/#rule1">maximize use of semantic HTML</a>
and heeding the warning that
<a href="{{ '/aria/apg/practices/read-me-first/#no_aria_better_bad_aria' | relative_url }}">No ARIA is better than Bad ARIA</a>.
</li>
</ul>

</aside>
<div class="sidebar-right"><h2 class="followed-by-support-notice">About This Example</h2><img alt=""
src="/assets/img/accordion.svg"
class="example-page-example-icon"
>
</details>
<img alt=""
src="{{ '/content-images/wai-aria-practices/img/accordion.svg' | relative_url }}"
class="example-page-example-icon"
>

<div>

<p>
The below example section contains a simple personal information input form divided into 3 sections
that demonstrates the
<a href="/patterns/accordion/">design pattern for accordion</a>.
<a href="{{ '/aria/apg/patterns/accordion/' | relative_url }}">design pattern for accordion</a>.
</p>
<section>
<div class="example-header">
<h2 id="ex_label" tabindex="-1">Example</h2>
<h2 id="ex_label">Example</h2>
</div>
<div role="separator" id="ex_start_sep" aria-labelledby="ex_start_sep ex_label" aria-label="Start of"></div>
<div id="ex1">
Expand Down Expand Up @@ -196,7 +208,7 @@ lang: en
<div role="separator" id="ex_end_sep" aria-labelledby="ex_end_sep ex_label" aria-label="End of"></div>
</section>
<section>
<h2 id="kbd_label" tabindex="-1">Keyboard Support</h2>
<h2 id="kbd_label">Keyboard Support</h2>
<div class="table-wrap"><table aria-labelledby="kbd_label" class="def">
<thead>
<tr>
Expand Down Expand Up @@ -232,7 +244,7 @@ lang: en
</section>

<section>
<h2 id="rps_label" tabindex="-1">Role, Property, State, and Tabindex Attributes</h2>
<h2 id="rps_label">Role, Property, State, and Tabindex Attributes</h2>

<div class="table-wrap"><table aria-labelledby="rps_label" class="data attributes">
<thead>
Expand Down Expand Up @@ -295,15 +307,15 @@ lang: en
</section>

<section>
<h2 tabindex="-1" id="javascript-and-css-source-code">Javascript and CSS Source Code</h2>
<h2>Javascript and CSS Source Code</h2>
<ul id="css_js_files">
<li>CSS: <a href="css/accordion.css" type="tex/css">accordion.css</a></li>
<li>JavaScript: <a href="js/accordion.js" type="text/javascript">accordion.js</a></li>
</ul>
</section>

<section>
<h2 id="sc1_label" tabindex="-1">HTML Source Code</h2>
<h2 id="sc1_label">HTML Source Code</h2>
<div role="separator" id="sc1_start_sep" aria-labelledby="sc1_start_sep sc1_label" aria-label="Start of"></div>
<pre><code id="sc1"></code></pre>
<div role="separator" id="sc1_end_sep" aria-labelledby="sc1_end_sep sc1_label" aria-label="End of"></div>
Expand All @@ -314,13 +326,9 @@ lang: en
</section>

</div>
<nav>
<a href="/patterns/accordion/">Accordion Design Pattern in WAI-ARIA Authoring Practices 1.2</a>
</nav>

<script src="js/accordion.js"></script>
</div>
</div>


</div>
<script>
var SkipToConfig = {
Expand All @@ -333,4 +341,6 @@ lang: en
}
};
</script>
<script src="/assets/skipto.min.js"></script>
<script
src="{{ '/content-assets/wai-aria-practices/skipto.min.js' | relative_url }}"
></script>
Loading