Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate epoch descriptor #173

Closed
drskalman opened this issue Apr 21, 2020 · 4 comments
Closed

Investigate epoch descriptor #173

drskalman opened this issue Apr 21, 2020 · 4 comments
Assignees
Labels
review Implementation code review specification Additions and Updates to the Specification

Comments

@drskalman
Copy link
Contributor

Investigate the role of the epoch descriptor defined here:

https://github.com/paritytech/substrate/blob/master/client/consensus/epochs/src/lib.rs#L212

And spec if it is necessary for the spec to contains it.

@FlorianFranzen
Copy link
Contributor

According to the current host spec and the BABE research write up, the slot number is supposed to be reset at the beginning of each epoch.

Substrate does not do this, so it needs epoch descriptors to tracks the slot number at the beginning (and end) of each epoch. Therefore there is no need to add them to the spec at the moment.

@drskalman
Copy link
Contributor Author

the original description for the developer is:
"A new post-digest type NextConfigDescriptor is added. This descriptor can only be used at epoch transition, on the same block as NextEpochDescriptor. NextConfigDescriptor is optional, and modifies the config value of c and allowed_slots of the next upcoming epoch (same as the block NextEpochDescriptor points to)." in Issue #46

@FlorianFranzen
Copy link
Contributor

Indeed I think we closed this too soon. While we might not have to spec the ViableEpochDescriptor, we should take another look at the NextEpochDescriptor.

@FlorianFranzen FlorianFranzen added specification Additions and Updates to the Specification review Implementation code review labels Jul 10, 2020
@FlorianFranzen
Copy link
Contributor

This is included in #168 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Implementation code review specification Additions and Updates to the Specification
Projects
None yet
Development

No branches or pull requests

2 participants