Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review BABE implementation in Gossamer #227

Closed
lamafab opened this issue Jun 25, 2020 · 7 comments
Closed

Review BABE implementation in Gossamer #227

lamafab opened this issue Jun 25, 2020 · 7 comments
Assignees
@FlorianFranzen
Labels
review Implementation code review

Comments

@lamafab
Copy link
Contributor

lamafab commented Jun 25, 2020

No description provided.

@drskalman
Copy link
Contributor

@FlorianFranzen aiming to finish this till next week.

@FlorianFranzen FlorianFranzen added the review Implementation code review label Jul 7, 2020
@drskalman
Copy link
Contributor

drskalman commented Jul 8, 2020 •
edited by FlorianFranzen
Loading

A list of 2 things:

  • VRF (is schnorr signature implemented in go or is calling into Rust?)
  • NextEpochDescriptor.
  • Verify SCALE encoding of the digests.
    Done by the end of the week.

@drskalman
Copy link
Contributor

  • interal of VRF review moved to another ticket.
  • There has been no major issues just discussion in the channel.
  • NextEpochDescriptor is the only thing that is left but need to be specced.

@drskalman
Copy link
Contributor

@drskalman
Copy link
Contributor

Blocked by #46 for now. @FlorianFranzen gets back to review when the everything about the spec is clear.

@lamafab
Copy link
Contributor Author

lamafab commented Sep 16, 2020

@FlorianFranzen will review this after #168 is done.

@FlorianFranzen
Copy link
Contributor

Wrote up the last few things from my notes in ChainSafe/gossamer#1628 and ChainSafe/gossamer#1629.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FlorianFranzen FlorianFranzen

Labels
review Implementation code review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@FlorianFranzen @drskalman @lamafab