Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

게시물 CRUD #69

Merged
merged 10 commits into from
Mar 29, 2022
Merged

게시물 CRUD #69

merged 10 commits into from
Mar 29, 2022

Conversation

yeonsumia
Copy link
Collaborator

No description provided.

@yeonsumia yeonsumia changed the title Post crud 게시물 CRUD Mar 25, 2022
Copy link
Collaborator

@moonpiderman moonpiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료했습니다!

Copy link
Collaborator

@moonpiderman moonpiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@yeonsumia
Copy link
Collaborator Author

email로 search하던 것들 user_id로 변경했고, ManyToMany 이슈도 해결하였습니다.

Copy link
Collaborator

@moonpiderman moonpiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 추가하였습니다!

@moonpiderman
Copy link
Collaborator

Repository단을 보면서 들었던 생각인데 코드 규칙이 있어야할 것 같아요!
class name은 파스칼 케이스, api path에 적용되는 부분은 스네이크 케이스, 그 외에는 카멜케이스로 설정하는 게 어떨까요?

@yeonsumia
Copy link
Collaborator Author

Repository단을 보면서 들었던 생각인데 코드 규칙이 있어야할 것 같아요! class name은 파스칼 케이스, api path에 적용되는 부분은 스네이크 케이스, 그 외에는 카멜케이스로 설정하는 게 어떨까요?

네네! 코드 작성할 때 해당 규칙을 준수하면서 작성한 것 같은데 틀린 부분이 있었을까요?

@moonpiderman
Copy link
Collaborator

PostService 파일보시면 중간에 뱀이 있어요..!

@yeonsumia
Copy link
Collaborator Author

yeonsumia commented Mar 28, 2022

PostService 파일보시면 중간에 뱀이 있어요..!

혹시 findByUser_IdAndPlaylist_Title 이런 것 말씀하시는 건가요?

@moonpiderman
Copy link
Collaborator

PostService 파일보시면 중간에 뱀이 있어요..!

혹시 findByUser_IdAndPlaylist_Title 이런 것 말씀하시는 건가요?

네 맞습니다!

@yeonsumia yeonsumia merged commit 9c1a72d into develop Mar 29, 2022
@yeonsumia yeonsumia deleted the post-CRUD branch March 29, 2022 01:57
Copy link
Collaborator

@moonpiderman moonpiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants