Optimization: Use LIST_ instead of TAILQ_. #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the queue(3) manpage, TAILQ "operations run about 20%
slower than lists". So using LIST_ instead ought to make our code much faster.
But this optimization comes at a nonzero cost to other aspects of the code.
Notably:
When multiple items are added expiring all at the same time, they
will no longer be triggered in exactly the same order in which
they were added. (Since we have to add to lists at the head,
whereas we could add to tailqs at the tail.)
We need to use more stack space in timeouts_update, since we
can no longer concatenate many tailqs into one.
(Make sure to benchmark this before merging; it may not actually be
worthwhile. I have looked at the generated code, but not benchmarked it.
Also, I am not sure whether the issues I mention above make this patch a
bad idea or not.)