Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#416) ν”ŒλŸ¬κ·ΈμΈμ„ μ΄μš©ν•œ #418

Merged
merged 4 commits into from
Feb 20, 2024
Merged

πŸ”€ :: (#416) ν”ŒλŸ¬κ·ΈμΈμ„ μ΄μš©ν•œ #418

merged 4 commits into from
Feb 20, 2024

Conversation

yongbeomkwak
Copy link
Member

@yongbeomkwak yongbeomkwak commented Feb 18, 2024 •
edited by kimdaehee0824
Loading

πŸ’‘ λ°°κ²½ 및 κ°œμš”

PR을 ν•˜κ²Œ 된 λ¬Έμ œμƒν™©, λ°°κ²½ λ“± κ°œμš”μ— λŒ€ν•΄μ„œ μž‘μ„±ν•΄μ£Όμ„Έμš”!
ν”„λ‘œμ νŠΈ μ…‹νŒ…μ— ν•„μš”ν•œ κΈ°λŠ₯듀이 κΈ°λ³Έ Plugin에 뭉쳐 μžˆμ–΄μ„œ κ³΅ν†΅λœ 역할을 ν•˜λŠ” μ½”λ“œλ“€μ„ λ¬Άμ–΄ μƒˆλ‘œμš΄ ν”ŒλŸ¬κ·ΈμΈλ“€λ‘œ λ‚˜λˆŒ ν•„μš”λ₯Ό λŠκΌˆμŠ΅λ‹ˆλ‹€.
νΌλΈ”λ¦¬μ‹±μ˜ 경우 μŠ€ν¬λ¦°μƒ·/λ™μ˜μƒλ„ μΆ”κ°€ν•΄μ£Όλ©΄ μ’‹μ•„μš”!

Resolves: #416

πŸ“ƒ μž‘μ—…λ‚΄μš©

PRμ—μ„œ ν•œ μž‘μ—…μ„ μžμ„Ένžˆ μž‘μ„±ν•΄μ£Όμ„Έμš”!

  • DependencyPlgun을 λ§Œλ“€μ—ˆμŠ΅λ‹ˆλ‹€.

    • μ˜μ‘΄μ„±κ΄€λ ¨ κΈ°λŠ₯듀을 λͺ¨μ•„λ†¨μŠ΅λ‹ˆλ‹€.

  • EnvironmentPlugin

    • ν™˜κ²½ μ…‹νŒ…κ΄€λ ¨λœ κΈ°λŠ₯듀을 λͺ¨μ•„λ†¨μŠ΅λ‹ˆλ‹€.

  • make pg (ν”ŒλŸ¬κ·ΈμΈ 생성 λͺ…λ Ήμ–΄)

    • μžλ™μœΌλ‘œ ν”ŒλŸ¬κ·ΈμΈμ„ μƒμ„±ν•΄μ£ΌλŠ” 슀크립트 generatePlugin.swift νŒŒμΌμ„ λ§Œλ“€μ—ˆμŠ΅λ‹ˆλ‹€.
    • μž…λ ₯으둜 ν”ŒλŸ¬κ·ΈμΈ μž…λ ₯을 λ°›μŠ΅λ‹ˆλ‹€.

πŸ™‹β€β™‚οΈ λ¦¬λ·°λ…ΈνŠΈ

κ΅¬ν˜„ μ‹œμ— κ³ λ―Όμ΄μ—ˆλ˜ 점듀 ν˜Ήμ€ νŠΉμ • 뢀뢄에 λŒ€ν•œ μ˜λ„κ°€ μžˆμ—ˆλ‹€λ©΄ PR 리뷰의 이해λ₯Ό 돕기 μœ„ν•΄ μ„œμˆ ν•΄μ£Όμ„Έμš”!
λ˜ν•œ λ¦¬λ·°μ–΄μ—κ²Œ νŠΉμ • 뢀뢄에 λŒ€ν•œ 집쀑 ν˜Ήμ€ μ½”λ©˜νŠΈ ν˜Ήμ€ μ§ˆλ¬Έμ„ μš”μ²­ν•˜λŠ” κ²½μš°μ— μž‘μ„±ν•˜λ©΄ μ’‹μ•„μš”!
e.g. μž‘μ—…μ„ 끝내야할 μ‹œκ°„μ΄ μ–Όλ§ˆ μ—†μ–΄ ν™•μž₯μ„±λ³΄λ‹€λŠ” λ™μž‘μ„ μœ„μ£Όλ‘œ λ§Œλ“€μ—ˆμ–΄μš”! κ°μ•ˆν•˜κ³  λ¦¬λ·°ν•΄μ£Όμ„Έμš”!

  • ν”ŒλŸ¬κ·ΈμΈ 생성 λͺ…λ Ήμ–΄λ₯Ό pg둜 ν–ˆλŠ”λ° λ‹€λ₯Έ 의견 μžˆμœΌμ‹€κΉŒμš” ??
make pg

βœ… PR 체크리슀트

ν…œν”Œλ¦Ώ 체크리슀트 말고도 μΆ”κ°€μ μœΌλ‘œ ν•„μš”ν•œ μ²΄ν¬λ¦¬μŠ€νŠΈλŠ” μΆ”κ°€ν•΄μ£Όμ„Έμš”!

  • 이 μž‘μ—…μœΌλ‘œ 인해 변경이 ν•„μš”ν•œ λ¬Έμ„œκ°€ λ³€κ²½λ˜μ—ˆλ‚˜μš”? (e.g. XCConfig, λ…Έμ…˜, README)
  • 이 μž‘μ—…μ„ ν•˜κ³ λ‚˜μ„œ κ³΅μœ ν•΄μ•Όν•  νŒ€μ›λ“€μ—κ²Œ κ³΅μœ λ˜μ—ˆλ‚˜μš”? (e.g. "API 개발 μ™„λ£Œλμ–΄μš”", "XCConfig κ°’ μΆ”κ°€λ˜μ—ˆμ–΄μš”")
  • μž‘μ—…ν•œ μ½”λ“œκ°€ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ‚˜μš”?
  • Merge λŒ€μƒ λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€μš”?
  • PRκ³Ό κ΄€λ ¨ μ—†λŠ” μž‘μ—…μ΄ μžˆμ§€λŠ” μ•Šλ‚˜μš”?

🎸 기타

@yongbeomkwak yongbeomkwak self-assigned this Feb 18, 2024
@yongbeomkwak yongbeomkwak added ♻️ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§ βš™ Setting 개발 ν™˜κ²½ μ„ΈνŒ… labels Feb 18, 2024
@github-actions GitHub Actions
Copy link

βœ… Successful finished SwiftLint

@yongbeomkwak yongbeomkwak removed the request for review from youn9k February 18, 2024 09:04
kimdaehee0824
kimdaehee0824 approved these changes Feb 20, 2024
View reviewed changes
Makefile
@@ -16,3 +16,6 @@ reset:

feature:
python3 Scripts/generate_new_feature.py

pg:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

개인적 μ·¨ν–₯으둜 κ·Έλƒ₯ plugin 써도 λ κ±°κ°™μ•„μš”
λ‹€λ₯Έκ±°λŠ” λ‹€ μ•ˆμ€„μ˜€μœΌλ‹ˆ 톡일성도 μžˆλŠ”κ±° κ°™κ΅¬μš”. 참고만 ν•΄μ£Όμ„Έμš©

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make plugin 이 μ•ˆλ˜μ—¬ γ…‹γ…‹.. 기본으둜 λ­”κ°€ μžˆλŠ” 것 κ°™μ•„μš”

@yongbeomkwak
Copy link
Member Author

λ‹€λ₯Έ 후보 : add-on

@yongbeomkwak yongbeomkwak merged commit a8f8b2f into feature/414-setting-for-interface Feb 20, 2024
1 check passed
@yongbeomkwak yongbeomkwak deleted the 416-re-distribution-plugin branch February 20, 2024 14:50
@yongbeomkwak yongbeomkwak restored the 416-re-distribution-plugin branch February 21, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baekteun baekteun baekteun approved these changes

@kimdaehee0824 kimdaehee0824 kimdaehee0824 approved these changes

@KangTaeHoon KangTaeHoon Awaiting requested review from KangTaeHoon

Assignees

@yongbeomkwak yongbeomkwak

Labels
♻️ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§ βš™ Setting 개발 ν™˜κ²½ μ„ΈνŒ…
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yongbeomkwak @kimdaehee0824 @baekteun