🔀 :: (#458) ArtistViewModel 제거 #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baekteun
requested review from
yongbeomkwak,
kimdaehee0824,
KangTaeHoon and
youn9k
as code owners
✅ Successful finished SwiftLint |
✅ Assign 자동 지정을 성공했어요! |
baekteun
force-pushed
the
458-artist-screen-viewmodel-to-reactorkit
branch
from
4624868 to
89b8839
Compare
baekteun
force-pushed
the
458-remove-deprecated-artist-view-model
branch
from
7026cc1 to
d847940
Compare
kimdaehee0824
approved these changes
Mar 11, 2024
5 tasks
KangTaeHoon
approved these changes
Mar 11, 2024
yongbeomkwak
approved these changes
Mar 11, 2024
baekteun
force-pushed
the
458-artist-screen-viewmodel-to-reactorkit
branch
from
89b8839 to
ea327d4
Compare
baekteun
force-pushed
the
458-remove-deprecated-artist-view-model
branch
from
d847940 to
394c580
Compare
baekteun
force-pushed
the
458-artist-screen-viewmodel-to-reactorkit
branch
from
ea327d4 to
c04a966
Compare
baekteun
force-pushed
the
458-remove-deprecated-artist-view-model
branch
from
394c580 to
fb19c61
Compare
Base automatically changed from
458-artist-screen-viewmodel-to-reactorkit
to
develop
March 12, 2024 09:54
baekteun
force-pushed
the
458-remove-deprecated-artist-view-model
branch
from
fb19c61 to
904e407
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 배경 및 개요
deprecated된 ArtistViewModel을 제거해요.
Resolves: #458
📃 작업내용
#462 를 하며 deprecated된 ArtistViewModel의 코드를 완전히 제거해요.
✅ PR 체크리스트
XCConfig,노션,README)"API 개발 완료됐어요","XCConfig 값 추가되었어요")