๐ :: (#440) ๋๋ฉ์ธ ๋ชจ๋ ๋ถ๋ฆฌ 8์ฐจ #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KangTaeHoon
requested review from
yongbeomkwak,
kimdaehee0824,
youn9k and
baekteun
as code owners
github-actions
bot
added
โก๏ธ Performance
โ Successful finished SwiftLint |
โ Assign ์๋ ์ง์ ์ ์ฑ๊ณตํ์ด์! |
yongbeomkwak
approved these changes
Mar 11, 2024
baekteun
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐ์
๋๋ฉ์ธ ๋ชจ๋ ๋ถ๋ฆฌ 8์ฐจ (Last)
๋์: SongsDomain, PlayListDomain, UserDomain
Resolves: #440
๐ ์์ ๋ด์ฉ
๐โโ๏ธ ๋ฆฌ๋ทฐ๋ ธํธ
SongEntity์ ๊ฐ์ ๊ณตํต์ผ๋ก ์ฌ์ฉํ๋ entity๋๋ฌธ์ 3๊ฐ์ง ๋๋ฉ์ธ ๋ถ๋ฆฌ ์์ ์ ํ ๋ฒ์ ์ฒ๋ฆฌํ์์ต๋๋ค.
์๋น์ค ๋ ์ด์ด ์ ๊ฑฐ๋ #442 ์์ ์งํํฉ๋๋ค.
โ PR ์ฒดํฌ๋ฆฌ์คํธ
XCConfig,๋ ธ์ ,README)"API ๊ฐ๋ฐ ์๋ฃ๋์ด์","XCConfig ๊ฐ ์ถ๊ฐ๋์์ด์")๐ธ ๊ธฐํ