Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 :: (#478) Reactor전용 BaseViewController 추가 #481

Merged
merged 1 commit into from
Apr 5, 2024
Merged

🔀 :: (#478) Reactor전용 BaseViewController 추가 #481

merged 1 commit into from
Apr 5, 2024

Conversation

baekteun
Copy link
Member

@baekteun baekteun commented Apr 1, 2024

💡 배경 및 개요

ReactorKit이 본격적으로 도입됨에 따라 더 간결하고 쉽게 사용할 수 있는 BaseViewController를 추가해ㅛㅇ

Resolves: #478

📃 작업내용

  • BaseReactorViewController 작업
  • BaseStoryboardReactorViewController 작업

🙋‍♂️ 리뷰노트

override용 메서드를 추가로 만들까요?

✅ PR 체크리스트

템플릿 체크리스트 말고도 추가적으로 필요한 체크리스트는 추가해주세요!

  • 이 작업으로 인해 변경이 필요한 문서가 변경되었나요? (e.g. XCConfig, 노션, README)
  • 이 작업을 하고나서 공유해야할 팀원들에게 공유되었나요? (e.g. "API 개발 완료됐어요", "XCConfig 값 추가되었어요")
  • 작업한 코드가 정상적으로 동작하나요?
  • Merge 대상 브랜치가 올바른가요?
  • PR과 관련 없는 작업이 있지는 않나요?

@baekteun baekteun linked an issue Apr 1, 2024 that may be closed by this pull request
Reactor용 BaseViewController 추가 #478
Closed
@github-actions github-actions bot added the ✨ Feature 피쳐 개발 label Apr 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024 •
edited
Loading

✅ Successful finished SwiftLint

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

✅ Assign 자동 지정을 성공했어요!

@baekteun

@yongbeomkwak
Copy link
Member

override라 하면 어떤 것이 있을까요??

@baekteun
Copy link
Member Author

baekteun commented Apr 2, 2024 •
edited
Loading

override라 하면 어떤 것이 있을까요??

지금 작성된 코드를 기준으로하면 addView setLayout configureUI configureNavigation bindState bindAction 이 있을거같아요

@yongbeomkwak
Copy link
Member

엇 저는 좋은 것 같습니다 :)

yongbeomkwak
yongbeomkwak approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@yongbeomkwak yongbeomkwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.
스토리보드라 코드는 깔끔하네여

@baekteun baekteun force-pushed the 478-base-viewcontroller-for-reactor branch from db0e5c2 to f9dbbcc Compare April 3, 2024 12:02
@baekteun baekteun merged commit b78e5c2 into develop Apr 5, 2024
3 checks passed
@baekteun baekteun deleted the 478-base-viewcontroller-for-reactor branch April 5, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yongbeomkwak yongbeomkwak yongbeomkwak approved these changes

@KangTaeHoon KangTaeHoon KangTaeHoon approved these changes

@kimdaehee0824 kimdaehee0824 Awaiting requested review from kimdaehee0824 kimdaehee0824 is a code owner

@youn9k youn9k Awaiting requested review from youn9k youn9k is a code owner

Assignees

@baekteun baekteun

Labels
✨ Feature 피쳐 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reactor용 BaseViewController 추가
3 participants
@baekteun @yongbeomkwak @KangTaeHoon