Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#521) ์„œ์น˜ ํ“จ์ฒ˜๋ฅผ ReactorKit์œผ๋กœ ๋ฆฌํŒฉํ•ฉ๋‹ˆ๋‹ค. #522

Merged
merged 26 commits into from
May 10, 2024

Conversation

yongbeomkwak
Copy link
Member

@yongbeomkwak yongbeomkwak commented May 7, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

  • ๋ฆฌ๋‰ด์–ผ v2 ๋‹น์‹œ ์—‰๋ง์ง„์ฐฝ์ด์˜€๋˜ ์ฝ”๋“œ์— ๋Œ€ํ•œ ๋ฆฌํŒฉ์˜ ํ•„ใ…‡์„ฑ

Resolves: #521

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ๋ฃจํŠธ ์„œ์น˜ VC๋ฅผ ํŒฉํ† ๋ฆฌ๋กœ ๊ฐ์‹ธ MainTab์—์„œ๋Š” Factory๋กœ ์ƒ์„ฑํ•˜๊ฒŒ ๋ฐ”๊ฟˆ
  • ๋ฃจํŠธ ์„œ์น˜ ๋ทฐ์ปจ์„ ReactorKit์œผ๋กœ ๋ฆฌํŒฉํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

๊ตฌํ˜„ ์‹œ์— ๊ณ ๋ฏผ์ด์—ˆ๋˜ ์ ๋“ค ํ˜น์€ ํŠน์ • ๋ถ€๋ถ„์— ๋Œ€ํ•œ ์˜๋„๊ฐ€ ์žˆ์—ˆ๋‹ค๋ฉด PR ๋ฆฌ๋ทฐ์˜ ์ดํ•ด๋ฅผ ๋•๊ธฐ ์œ„ํ•ด ์„œ์ˆ ํ•ด์ฃผ์„ธ์š”!

๋˜ํ•œ ๋ฆฌ๋ทฐ์–ด์—๊ฒŒ ํŠน์ • ๋ถ€๋ถ„์— ๋Œ€ํ•œ ์ง‘์ค‘ ํ˜น์€ ์ฝ”๋ฉ˜ํŠธ ํ˜น์€ ์งˆ๋ฌธ์„ ์š”์ฒญํ•˜๋Š” ๊ฒฝ์šฐ์— ์ž‘์„ฑํ•˜๋ฉด ์ข‹์•„์š”!

e.g. ์ž‘์—…์„ ๋๋‚ด์•ผํ•  ์‹œ๊ฐ„์ด ์–ผ๋งˆ ์—†์–ด ํ™•์žฅ์„ฑ๋ณด๋‹ค๋Š” ๋™์ž‘์„ ์œ„์ฃผ๋กœ ๋งŒ๋“ค์—ˆ์–ด์š”! ๊ฐ์•ˆํ•˜๊ณ  ๋ฆฌ๋ทฐํ•ด์ฃผ์„ธ์š”!

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

Copy link

github-actions bot commented May 7, 2024

โœ… Successful finished SwiftLint

Copy link

github-actions bot commented May 7, 2024

โœ… ์ด์Šˆ์™€ PR์˜ Labels ๋™๊ธฐํ™”๋ฅผ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@baekteun baekteun changed the base branch from develop to 519-split-tab-storage-myinfo May 7, 2024 06:22
Base automatically changed from 519-split-tab-storage-myinfo to develop May 8, 2024 08:40
Copy link
Member

@baekteun baekteun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ณ„๊ฐœ๋กœ bind(_:) ๋ฅผ ํ†ตํ•ด ๊ตฌ๋…ํ•œ ๊ฒƒ๋“ค์€ trailing ํด๋กœ์ ธ๋กœ ์‚ฌ์šฉํ•˜๋Š”๊ฑฐ ์–ด๋–ค๊ฐ€์š”?
bind๊ฐ€ ๋ฐ›๋Š” ํŒŒ๋ผ๋ฏธํ„ฐ์— ํด๋กœ์ ธ๊ฐ€ ํ•˜๋‚˜๋ฐ–์— ์—†๋‹ค๋ณด๋‹ˆ ํŒŒ๋ผ๋ฏธํ„ฐ label์„ ๋ช…์‹œํ•ด์ฃผ์ง€ ์•Š์•„๋„ ๋˜์–ด์„œ ๋” ๊น”๋”ํ• ๊ฒƒ๊ฐ™์•„์„œ์š”

@yongbeomkwak yongbeomkwak merged commit f2874a1 into develop May 10, 2024
3 checks passed
@yongbeomkwak yongbeomkwak deleted the 521-refactor-search branch May 10, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search ํ“จ์ฒ˜๋ฅผ ReactorKit์œผ๋กœ ๋ฆฌํŒฉํ•ฉ๋‹ˆ๋‹ค.
2 participants