Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#511) v3.0 api ๋ณ€๊ฒฝ์  ์ ์šฉ - Artist Domain #539

Merged
merged 25 commits into from
May 15, 2024

Conversation

KangTaeHoon
Copy link
Contributor

@KangTaeHoon KangTaeHoon commented May 13, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๐Ÿ”€ :: (#511) v3.0 api ๋ณ€๊ฒฝ์  ์ ์šฉ - Artist Domain

Resolves: #511

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

v3.0 api ๋ณ€๊ฒฝ์  ์ ์šฉ
DTO, Entity: ๋ถˆํ•„์š” ์š”์†Œ ์‚ญ์ œ

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

XCConfig.Secrets(ignore) ๋„๋ฉ”์ธ์„ ๋ฐ”๊ฟ”์•ผ ์ •์ƒ์ ์œผ๋กœ ๋Œ์•„๊ฐ.
IntroVC์— failure ์ผ€์ด์Šค๊ฐ€ ๋“ค์–ด์™€๋„ ๋‹ค์Œ ํ™”๋ฉด์œผ๋กœ ์ด๋™ํ•˜๋Š” ์ฝ”๋“œ๊ฐ€ ์ž„์‹œ๋กœ ๋“ค์–ด๊ฐ(#warning)

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

Copy link

github-actions bot commented May 13, 2024

โœ… Successful finished SwiftLint

Copy link

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@KangTaeHoon

@baekteun
Copy link
Member

๋ญ์ง€ CI๋Š” ์‹คํŒจํ–ˆ๋Š”๋ฐ Checks๋Š” ๊ณ„์† ๋Œ์•„๊ฐ€๋„ค์š”
image

KangTaeHoon and others added 4 commits May 15, 2024 23:10
๐Ÿ”€ :: (#507) v3.0 api ๋ณ€๊ฒฝ์  ์ ์šฉ - Song Domain
๐Ÿ”€ :: (#512) v3.0 api ๋ณ€๊ฒฝ์  ์ ์šฉ - Chart Domain
@yongbeomkwak
Copy link
Member

๋‹ˆ๋“ค์ด ์ปจํ”Œ๋ฆญํŠธ ๋ฐœ์ƒ~

@KangTaeHoon KangTaeHoon merged commit 2728abe into develop May 15, 2024
3 checks passed
@KangTaeHoon KangTaeHoon deleted the 511-update-domain-artist branch May 15, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArtistDomain - API ๋ณ€๊ฒฝ์‚ฌํ•ญ ๋ฐ˜์˜
3 participants