Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#550) ๋‚ด์ •๋ณด ํƒญ์„ ๊ตฌํ˜„ํ•ฉ๋‹ˆ๋‹ค. #565

Merged
merged 39 commits into from
Jun 11, 2024

Conversation

youn9k
Copy link
Member

@youn9k youn9k commented Jun 4, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๋‚ด ์ •๋ณด ํƒญ์„ ๊ตฌํ˜„ํ–ˆ์–ด์š”

๋‚ด์ •๋ณด ํƒญ ์„ค์ • ํƒญ
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-04.at.16.30.00.mov
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-04.at.16.09.28.mov

Resolves: #550

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ๋‚ด ์ •๋ณด ํƒญ UI
  • ์„ค์ • ํƒญ UI
  • ๊ฐ ๋ฒ„ํŠผ๋“ค ๊ธฐ๋Šฅ ์—ฐ๊ฒฐ

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

  • ๋”๋ณด๊ธฐ(์  3๊ฐœ) ๊ธฐ๋Šฅ ์ถ”๊ฐ€ ์˜ˆ์ •
  • ๋ฝ‘๊ธฐ ํ™”๋ฉด ์ด๋™ ๊ธฐ๋Šฅ ์ถ”๊ฐ€ ์˜ˆ์ •
  • ํŒฌ๋ชจ๋‹ฌ์— ๋ฒ„๊ทธ๊ฐ€ ์žˆ์–ด ํŒฌ๋ชจ๋‹ฌ์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„๋“ค์€ ์ฃผ์„์ฒ˜๋ฆฌํ•˜๊ณ  present๋กœ ๋Œ€์ฒด ํ•ด๋’€์Šต๋‹ˆ๋‹ค.
  • ์ฝ”๋“œ ์ด๋™ ๋ฆฌ์†Œ์Šค ์ถ”๊ฐ€ ๋“ฑ ์ž์งˆ๊ตฌ๋ ˆํ•œ ์ž‘์—…๋“ค์ด ๋งŽ์•˜์–ด์„œ, MyInfoFeature/.. ์œ„์ฃผ๋กœ ๋ณด์‹œ๋ฉด ๋ฉ๋‹ˆ๋‹ค!

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

youn9k added 30 commits May 30, 2024 09:27
์˜คํ”ˆ์†Œ์Šค, ์„œ๋น„์Šค์ด์šฉ์•ฝ๊ด€, ๊ณต์ง€์‚ฌํ•ญ, ์ž์ฃผ๋ฌป๋Š”์งˆ๋ฌธ, ๋ฌธ์˜ํ•˜๊ธฐ
3.0์—์„œ ๋น ์ง„ ๋””์ž์ธ์ด์ง€๋งŒ ์ผ๋‹จ ์˜ฎ๊ฒจ๋’€์Šต๋‹ˆ๋‹ค
@youn9k youn9k added the โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ label Jun 4, 2024
@youn9k youn9k self-assigned this Jun 4, 2024
Copy link
Member

@baekteun baekteun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜ค์šฐ.. ๊ต‰์žฅํžˆ.. ํฌ๋„ค์š”.. ์„ค์ • ํŽ˜์ด์ง€๋‚˜ ์ผ๋ถ€ ์ •๋„๋Š” ๋ถ„๋ฆฌํ–ˆ์—ˆ์œผ๋ฉด ๋งค์šฐ ์ข‹์•˜์„๊ฑฐ๊ฐ™์•„์—ฌ

ref : https://www.youtube.com/watch?v=XRZPkYnWa48

@youn9k
Copy link
Member Author

youn9k commented Jun 4, 2024

์˜ค์šฐ.. ๊ต‰์žฅํžˆ.. ํฌ๋„ค์š”.. ์„ค์ • ํŽ˜์ด์ง€๋‚˜ ์ผ๋ถ€ ์ •๋„๋Š” ๋ถ„๋ฆฌํ–ˆ์—ˆ์œผ๋ฉด ๋งค์šฐ ์ข‹์•˜์„๊ฑฐ๊ฐ™์•„์—ฌ

ref : https://www.youtube.com/watch?v=XRZPkYnWa48

๊ทธ๋Ÿฌ๊ฒŒ์š”ใ…œ ๋‹ค์Œ๋ถ€ํ„ด ์ข€ ์ž˜๊ฒŒ์ชผ๊ฐœ์„œ ํ•ด๋ณด๊ฒ ์Šต๋‹ˆ๋‹ค๐Ÿฅฒ

@yongbeomkwak
Copy link
Member

์˜ค์šฐ 112 ใ…‹ใ…‹ใ…‹..

@yongbeomkwak
Copy link
Member

์ปจํ”Œ๋ฆญํŠธ๊ฐ€ ์žˆ๋„นใ……

@youn9k
Copy link
Member Author

youn9k commented Jun 5, 2024

์ปจํ”Œ๋ฆญํŠธ๊ฐ€ ์žˆ๋„นใ……

์˜ค์ž‰ self ์บก์ณ๊ฐ€ ์™œ์‚ฌ๋ผ์กŒ์„๊นŒ์š”

localTable["keychain-any Keychain"] = { self.keychain as Any }
localTable["keychain-any Keychain"] = { [unowned self] in self.keychain as Any }

Copy link

github-actions bot commented Jun 7, 2024

โœ… Successful finished SwiftLint

@youn9k
Copy link
Member Author

youn9k commented Jun 7, 2024

์ปจํ”Œ๋ฆญํŠธ๊ฐ€ ์žˆ๋„นใ……

๋นŒ๋“œํ•˜๋ฉด self ์บก์ณ๊ฐ€ ์‚ฌ๋ผ์ ธ์„œ ์บก์ณ ์—†๋Š”๊ฑธ๋กœ resolve ํ–ˆ์Šต๋‹ˆ๋‹ค

@KangTaeHoon
Copy link
Contributor

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-06-09 แ„‹แ…ฉแ„Œแ…ฅแ†ซ 7 33 11

์•„์ดํ…œ์ด ๋Š˜์–ด๋‚œ๋‹ค๋˜์ง€, ์ž‘์€ ๊ธฐ๊ธฐ์—์„œ๋Š” ์Šคํฌ๋กค์ด ํ•„์š”ํ•  ์ˆ˜๋„ ์žˆ๋Š” ๊ณ ๋ ค๋Š” ์—†์–ด๋ณด์ด๋„ค์š”.

@youn9k
Copy link
Member Author

youn9k commented Jun 9, 2024

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-06-09 แ„‹แ…ฉแ„Œแ…ฅแ†ซ 7 33 11

์•„์ดํ…œ์ด ๋Š˜์–ด๋‚œ๋‹ค๋˜์ง€, ์ž‘์€ ๊ธฐ๊ธฐ์—์„œ๋Š” ์Šคํฌ๋กค์ด ํ•„์š”ํ•  ์ˆ˜๋„ ์žˆ๋Š” ๊ณ ๋ ค๋Š” ์—†์–ด๋ณด์ด๋„ค์š”.

์•— ๊ทธ๋Ÿฌ๋„ค์š” ๋ณด์™„ํ•ด๋ณผ๊ฒŒ์š”

@youn9k
Copy link
Member Author

youn9k commented Jun 10, 2024

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-06-09 แ„‹แ…ฉแ„Œแ…ฅแ†ซ 7 33 11

์•„์ดํ…œ์ด ๋Š˜์–ด๋‚œ๋‹ค๋˜์ง€, ์ž‘์€ ๊ธฐ๊ธฐ์—์„œ๋Š” ์Šคํฌ๋กค์ด ํ•„์š”ํ•  ์ˆ˜๋„ ์žˆ๋Š” ๊ณ ๋ ค๋Š” ์—†์–ด๋ณด์ด๋„ค์š”.

์•„์ดํ…œ์ด ๋Š˜์–ด๋‚˜ ์ž‘์€ ํ™”๋ฉด์—์„œ ์งค๋ฆด ๊ฒฝ์šฐ ์Šคํฌ๋กคํ•  ์ˆ˜ ์žˆ๋„๋ก ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-10.at.17.43.30.mov

@KangTaeHoon
Copy link
Contributor

AnswerTableViewCell.swift์—์„œ ์ถฉ๋Œ ๋‚ฌ๋‹ค๋Š”๋ฐ, ๊ฑฐ๊ธฐ FAQ ๋„๋ฉ”์ธ ๋ณ€๊ฒฝ์‚ฌํ•ญ ๋ฐ˜์˜ํ•˜๋Š๋ผ ๋ณ€๊ฒฝ๋œ๊ฒŒ ์žˆ์–ด์š”. ๋””๋ฒจ๋กญ์ชฝ์œผ๋กœ ๋ณ‘ํ•ฉํ•ด์ฃผ์„ธ์š”.

@yongbeomkwak
Copy link
Member

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-06-09 แ„‹แ…ฉแ„Œแ…ฅแ†ซ 7 33 11
์•„์ดํ…œ์ด ๋Š˜์–ด๋‚œ๋‹ค๋˜์ง€, ์ž‘์€ ๊ธฐ๊ธฐ์—์„œ๋Š” ์Šคํฌ๋กค์ด ํ•„์š”ํ•  ์ˆ˜๋„ ์žˆ๋Š” ๊ณ ๋ ค๋Š” ์—†์–ด๋ณด์ด๋„ค์š”.

์•„์ดํ…œ์ด ๋Š˜์–ด๋‚˜ ์ž‘์€ ํ™”๋ฉด์—์„œ ์งค๋ฆด ๊ฒฝ์šฐ ์Šคํฌ๋กคํ•  ์ˆ˜ ์žˆ๋„๋ก ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-10.at.17.43.30.mov

@KangTaeHoon ์•„๋งˆ ๊ตฌ๊ตฌ๋‹˜์ด ๋งํ•œ๊ฑฐ๋Š” ๊ฐ€๋กœ ์Šคํฌ๋กค ์–˜๊ธฐํ•˜๋Š”๊ฑฐ ์•„๋‹๊นŒ์š”?

@KangTaeHoon
Copy link
Contributor

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-06-09 แ„‹แ…ฉแ„Œแ…ฅแ†ซ 7 33 11
์•„์ดํ…œ์ด ๋Š˜์–ด๋‚œ๋‹ค๋˜์ง€, ์ž‘์€ ๊ธฐ๊ธฐ์—์„œ๋Š” ์Šคํฌ๋กค์ด ํ•„์š”ํ•  ์ˆ˜๋„ ์žˆ๋Š” ๊ณ ๋ ค๋Š” ์—†์–ด๋ณด์ด๋„ค์š”.

์•„์ดํ…œ์ด ๋Š˜์–ด๋‚˜ ์ž‘์€ ํ™”๋ฉด์—์„œ ์งค๋ฆด ๊ฒฝ์šฐ ์Šคํฌ๋กคํ•  ์ˆ˜ ์žˆ๋„๋ก ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-10.at.17.43.30.mov

@KangTaeHoon ์•„๋งˆ ๊ตฌ๊ตฌ๋‹˜์ด ๋งํ•œ๊ฑฐ๋Š” ๊ฐ€๋กœ ์Šคํฌ๋กค ์–˜๊ธฐํ•˜๋Š”๊ฑฐ ์•„๋‹๊นŒ์š”?

์„ธ๋กœ๊ฐ€ ๋งž์•„์š”~

@youn9k
Copy link
Member Author

youn9k commented Jun 10, 2024

AnswerTableViewCell.swift์—์„œ ์ถฉ๋Œ ๋‚ฌ๋‹ค๋Š”๋ฐ, ๊ฑฐ๊ธฐ FAQ ๋„๋ฉ”์ธ ๋ณ€๊ฒฝ์‚ฌํ•ญ ๋ฐ˜์˜ํ•˜๋Š๋ผ ๋ณ€๊ฒฝ๋œ๊ฒŒ ์žˆ์–ด์š”. ๋””๋ฒจ๋กญ์ชฝ์œผ๋กœ ๋ณ‘ํ•ฉํ•ด์ฃผ์„ธ์š”.

๋ฐ˜์˜ ์™„๋ฃŒ

@youn9k youn9k merged commit 5e28934 into develop Jun 11, 2024
3 checks passed
@youn9k youn9k deleted the feature/550-my-info branch June 11, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โœจ Feature ํ”ผ์ณ ๊ฐœ๋ฐœ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๋‚ด ์ •๋ณด ํ™”๋ฉด ๊ตฌํ˜„
4 participants