Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#569) ์„ค์ • ํ™”๋ฉด ์ปดํฌ๋„ŒํŠธ๋ฅผ Stub ํ•˜๊ธฐ ์œ„ํ•œ ์™ธ๋ถ€ ๋ชจ๋“ˆ Stub #576

Merged
merged 21 commits into from
Jun 11, 2024

Conversation

youn9k
Copy link
Member

@youn9k youn9k commented Jun 5, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

๋‚ด ์ •๋ณด ํ™”๋ฉด์€ ๊ฐ™์€ ๋ชจ๋“ˆ ๋‚ด ์„ค์ • ํ™”๋ฉด์„ ์˜์กดํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.
๋‹ค์‹œ ์„ค์ • ํ™”๋ฉด์€ ์™ธ๋ถ€ ๋ชจ๋“ˆ๋“ค์˜ ํ™”๋ฉด(ex. ์„œ๋น„์Šค ์ด์šฉ์•ฝ๊ด€, ๊ฐœ์ธ์ •๋ณด ์ฒ˜๋ฆฌ๋ฐฉ์นจ ๋“ฑ)๋“ค์„ ์˜์กดํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.
์ตœ์ข…์ ์œผ๋กœ ๋‚ด ์ •๋ณด ํ™”๋ฉด์˜ Demo ๋ฅผ ๋งŒ๋“ค๊ธฐ ์œ„ํ•ด, ์„ค์ •ํ™”๋ฉด์˜ Stub์„ ๋งŒ๋“ค๊ธฐ ์œ„ํ•œ ์™ธ๋ถ€ ๋ชจ๋“ˆ๋“ค์˜ Stub ๊ฐ์ฒด๋ฅผ ์ƒ์„ฑํ•ด์•ผ ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • AuthDomain Spy ๊ฐ์ฒด ์ถ”๊ฐ€
  • UserDomain Spy ๊ฐ์ฒด ์ถ”๊ฐ€
  • BaseFeature Stub ๊ฐ์ฒด ์ถ”๊ฐ€
  • SignInFeature Stub ๊ฐ์ฒด ์ถ”๊ฐ€

๐Ÿ™‹โ€โ™‚๏ธ ๋ฆฌ๋ทฐ๋…ธํŠธ

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. XCConfig, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "XCConfig ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

https://www.youtube.com/watch?v=XRZPkYnWa48
์œ„ ์˜์ƒ์„ ๋ณด๊ณ  Stacked Changes๋ฅผ ํ•ด๋ณด๋ ค๊ณ  ํ•ฉ๋‹ˆ๋‹ค!

@youn9k youn9k added the โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง label Jun 5, 2024
@youn9k youn9k self-assigned this Jun 5, 2024
Copy link

github-actions bot commented Jun 5, 2024

โœ… Successful finished SwiftLint

Copy link

github-actions bot commented Jun 5, 2024

โœ… Assign ์ž๋™ ์ง€์ •์„ ์„ฑ๊ณตํ–ˆ์–ด์š”!

@youn9k

@baekteun
Copy link
Member

baekteun commented Jun 6, 2024

์˜ค์šฐ ๊ณ ์ƒํ•˜์‹œ๋Š”๊ฑธ ๋ณด๋‹ˆ sourcery๋‚˜ mockolo๊ฐ€ ์ข€ ํ•„์š”์„ฑ์ด ๋Œ€๋‘๋˜๋„ค์š”

@youn9k
Copy link
Member Author

youn9k commented Jun 6, 2024

์˜ค์šฐ ๊ณ ์ƒํ•˜์‹œ๋Š”๊ฑธ ๋ณด๋‹ˆ sourcery๋‚˜ mockolo๊ฐ€ ์ข€ ํ•„์š”์„ฑ์ด ๋Œ€๋‘๋˜๋„ค์š”

ใ…‹ใ…‹ใ…‹ใ…‹์ ์  ์•ผํฌ์‰์ด๋น™์ด ๋˜๊ฐ€๋Š” ๋Š๋‚Œ

youn9k added 2 commits June 6, 2024 20:36
๐Ÿ”€ :: (#577) SignInFeature์— KeyChainModule ์˜์กด์„ฑ์„ ์ถ”๊ฐ€ํ•ฉ๋‹ˆ๋‹ค.
@youn9k youn9k added the โœ… Test Test ๊ด€๋ จ label Jun 6, 2024
Base automatically changed from feature/550-my-info to develop June 11, 2024 08:48
@youn9k youn9k merged commit 3786bd1 into develop Jun 11, 2024
1 check passed
@youn9k youn9k deleted the feature/569-setting-factory-stub branch June 11, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง โœ… Test Test ๊ด€๋ จ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants